You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/08 03:23:32 UTC

[GitHub] [rocketmq] horizonzy opened a new issue #2571: The judgement in org.apache.rocketmq.store.ConsumeQueue#truncateDirtyLogicFiles maybe exist problem.

horizonzy opened a new issue #2571:
URL: https://github.com/apache/rocketmq/issues/2571


   **BUG REPORT**
   
   1. Please describe the issue you observed:
   the method `truncateDirtyLogicFiles` is to delete the consumeQueue data which ahead of commit log.
    
   The judgemnt which check consume data is more than commitlog exist as follow:
   https://github.com/apache/rocketmq/blob/39bb9386f10d5d8dfe81183c172a3a86f6d313bd/store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java#L263
   
   In fact, use `if (offset + size >= phyOffet)` will be better. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org