You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/04/13 13:34:57 UTC
[camel] 01/08: CAMEL-17763: cleanup unused exceptions in camel-groovy
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit dd105dd2226d24a08aba19fd05e0c11c5acb9a81
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Mon Apr 11 14:06:22 2022 +0200
CAMEL-17763: cleanup unused exceptions in camel-groovy
---
.../org/apache/camel/language/groovy/GroovyExpressionTest.java | 10 +++++-----
.../apache/camel/language/groovy/GroovyInvokeMethodTest.java | 4 ++--
.../org/apache/camel/language/groovy/GroovyLanguageTest.java | 2 +-
.../org/apache/camel/language/groovy/GroovyListMapTest.java | 4 ++--
.../org/apache/camel/language/groovy/GroovyResourceTest.java | 4 ++--
.../camel/language/groovy/GroovyScriptingLanguageTest.java | 4 ++--
.../apache/camel/language/groovy/GroovySetFixedHeaderTest.java | 4 ++--
.../org/apache/camel/language/groovy/GroovySetHeaderTest.java | 4 ++--
.../apache/camel/language/groovy/LanguageGroovyRouteTest.java | 2 +-
.../processor/groovy/GroovySetHeaderConcurrentIssueTest.java | 4 ++--
.../camel/processor/groovy/GroovySetHeaderIssueTest.java | 4 ++--
11 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyExpressionTest.java b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyExpressionTest.java
index 1e39d26d5e0..8fb5cf7a726 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyExpressionTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyExpressionTest.java
@@ -36,14 +36,14 @@ public class GroovyExpressionTest {
protected Exchange exchange;
@Test
- public void testExpressionReturnsTheCorrectValue() throws Exception {
+ public void testExpressionReturnsTheCorrectValue() {
assertExpression(GroovyLanguage.groovy("exchange.in.headers['foo.bar']"), exchange, "cheese");
assertExpression(GroovyLanguage.groovy("exchange.in.headers.name"), exchange, "James");
assertExpression(GroovyLanguage.groovy("exchange.in.headers['doesNotExist']"), exchange, null);
}
@Test
- public void testPredicateEvaluation() throws Exception {
+ public void testPredicateEvaluation() {
assertPredicate(GroovyLanguage.groovy("exchange.in.headers.name == 'James'"), exchange, true);
assertPredicate(GroovyLanguage.groovy("exchange.in.headers.name == 'Hiram'"), exchange, false);
@@ -51,14 +51,14 @@ public class GroovyExpressionTest {
}
@Test
- public void testProcessorMutatesTheExchange() throws Exception {
+ public void testProcessorMutatesTheExchange() {
GroovyLanguage.groovy("request.headers.myNewHeader = 'ABC'").evaluate(exchange);
assertInMessageHeader(exchange, "myNewHeader", "ABC");
}
@Test
- public void testInvalidExpressionFailsWithMeaningfulException() throws Exception {
+ public void testInvalidExpressionFailsWithMeaningfulException() {
try {
GroovyLanguage.groovy("exchange.doesNotExist").evaluate(exchange);
fail("This test case should have thrown an exception!");
@@ -70,7 +70,7 @@ public class GroovyExpressionTest {
}
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
exchange = new DefaultExchange(new DefaultCamelContext());
exchange.getIn().setHeader("foo.bar", "cheese");
exchange.getIn().setHeader("name", "James");
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyInvokeMethodTest.java b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyInvokeMethodTest.java
index 65728752640..ea89b0ad7e7 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyInvokeMethodTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyInvokeMethodTest.java
@@ -37,10 +37,10 @@ public class GroovyInvokeMethodTest extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:start")
.setHeader("name").groovy("request.body.name")
.setHeader("dangerous").groovy("request.body.isDangerous()")
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyLanguageTest.java b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyLanguageTest.java
index c4f6759746c..4e5aadfc201 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyLanguageTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyLanguageTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class GroovyLanguageTest extends LanguageTestSupport {
@Test
- public void testGroovyExpressions() throws Exception {
+ public void testGroovyExpressions() {
assertExpression("exchange.in.headers.foo", "abc");
assertExpression("request.headers.foo", "abc");
assertExpression("headers.foo", "abc");
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyListMapTest.java b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyListMapTest.java
index 2a3e182af72..cc78df50258 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyListMapTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyListMapTest.java
@@ -47,9 +47,9 @@ public class GroovyListMapTest extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
- public void configure() throws Exception {
+ public void configure() {
from("direct:start")
.filter().groovy("request.body.get(0).get('foo') == 'bar'")
.to("mock:result");
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyResourceTest.java b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyResourceTest.java
index 0813dbbbb2c..0cedcb42ab3 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyResourceTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyResourceTest.java
@@ -35,10 +35,10 @@ public class GroovyResourceTest extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:start")
.transform().groovy("resource:classpath:mygroovy.groovy")
.to("mock:result");
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyScriptingLanguageTest.java b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyScriptingLanguageTest.java
index 8e3475a6e8b..0e0ff9c7a16 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyScriptingLanguageTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovyScriptingLanguageTest.java
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
public class GroovyScriptingLanguageTest extends CamelTestSupport {
@Test
- public void testScripting() throws Exception {
+ public void testScripting() {
Language lan = context.resolveLanguage("groovy");
Assertions.assertTrue(lan instanceof ScriptingLanguage);
ScriptingLanguage slan = (ScriptingLanguage) lan;
@@ -43,7 +43,7 @@ public class GroovyScriptingLanguageTest extends CamelTestSupport {
}
@Test
- public void testExternalScripting() throws Exception {
+ public void testExternalScripting() {
Language lan = context.resolveLanguage("groovy");
Assertions.assertTrue(lan instanceof ScriptingLanguage);
ScriptingLanguage slan = (ScriptingLanguage) lan;
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovySetFixedHeaderTest.java b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovySetFixedHeaderTest.java
index a9c1808b0a6..ca75844c6ea 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovySetFixedHeaderTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovySetFixedHeaderTest.java
@@ -37,10 +37,10 @@ public class GroovySetFixedHeaderTest extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:start")
.setHeader("beer", groovy("'Carlsberg'"))
.to("mock:result");
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovySetHeaderTest.java b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovySetHeaderTest.java
index 3845811e607..97a99879477 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovySetHeaderTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/GroovySetHeaderTest.java
@@ -48,10 +48,10 @@ public class GroovySetHeaderTest extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:start")
.setHeader("drink").groovy("request.headers.beer")
// shows how to access the camelContext value
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/LanguageGroovyRouteTest.java b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/LanguageGroovyRouteTest.java
index 414a88dfa98..70bda288017 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/LanguageGroovyRouteTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/language/groovy/LanguageGroovyRouteTest.java
@@ -34,7 +34,7 @@ public class LanguageGroovyRouteTest extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
public void configure() throws Exception {
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/processor/groovy/GroovySetHeaderConcurrentIssueTest.java b/components/camel-groovy/src/test/java/org/apache/camel/processor/groovy/GroovySetHeaderConcurrentIssueTest.java
index 0f2e8dc80dd..078c15c39a1 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/processor/groovy/GroovySetHeaderConcurrentIssueTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/processor/groovy/GroovySetHeaderConcurrentIssueTest.java
@@ -73,10 +73,10 @@ public class GroovySetHeaderConcurrentIssueTest extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:start")
.setHeader("mySlip").groovy("return \"${request.body.subOrderName}Endpoint\"")
.routingSlip(header("mySlip"));
diff --git a/components/camel-groovy/src/test/java/org/apache/camel/processor/groovy/GroovySetHeaderIssueTest.java b/components/camel-groovy/src/test/java/org/apache/camel/processor/groovy/GroovySetHeaderIssueTest.java
index 7663c881b38..41afe1e1136 100644
--- a/components/camel-groovy/src/test/java/org/apache/camel/processor/groovy/GroovySetHeaderIssueTest.java
+++ b/components/camel-groovy/src/test/java/org/apache/camel/processor/groovy/GroovySetHeaderIssueTest.java
@@ -56,10 +56,10 @@ public class GroovySetHeaderIssueTest extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:start")
.setHeader("mySlip").groovy("return \"${request.body.subOrderName}Endpoint\"")
.routingSlip(header("mySlip"));