[jira] Commented: (HADOOP-5449) Verify if JobHistory.HistoryCleaner works as expected

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-5449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680885#action_12680885 ] 

Hadoop QA commented on HADOOP-5449:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12401918/patch-5449.txt
  against trunk revision 752405.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/50/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/50/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/50/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/50/console

This message is automatically generated.

> Verify if JobHistory.HistoryCleaner works as expected
> -----------------------------------------------------
>
>                 Key: HADOOP-5449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5449
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: patch-5449.txt
>
>
> Here is the piece of code I doubt
> {code}
> public void run(){
>       if (isRunning){
>         return;
>       }
>       now = System.currentTimeMillis();
>       // clean history only once a day at max
>       if (lastRan ==0 || (now - lastRan) < ONE_DAY_IN_MS){
>         return;
>       }
>       lastRan = now;
> .....
> // main code for cleaning
> }
> {code}
> {{lastRun}} is initialized to 0 and hence HistoryCleaner will never execute the main code. Also a testcase should be written for JobHistory.HistoryCleaner to check if it works as expected. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.