You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2008/03/01 14:30:51 UTC
[jira] Created: (LUCENE-1198) Exception in
DocumentsWriter.ThreadState.init leads to corruption
Exception in DocumentsWriter.ThreadState.init leads to corruption
-----------------------------------------------------------------
Key: LUCENE-1198
URL: https://issues.apache.org/jira/browse/LUCENE-1198
Project: Lucene - Java
Issue Type: Bug
Components: Index
Affects Versions: 2.3
Reporter: Michael McCandless
Assignee: Michael McCandless
Priority: Minor
Fix For: 2.4
If an exception is hit in the init method, DocumentsWriter incorrectly
increments numDocsInRAM when in fact the document is not added.
Spinoff of this thread:
http://markmail.org/message/e76hgkgldxhakuaa
The root cause that led to the exception in init was actually due to
incorrect use of Lucene's APIs (one thread still modifying the
Document while IndexWriter.addDocument is adding it) but still we
should protect against any exceptions coming out of init.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: [jira] Updated: (LUCENE-1198) Exception in DocumentsWriter.ThreadState.init
leads to corruption
Posted by Chris Hostetter <ho...@fucit.org>.
: Thanks Hoss!
I did the easy book-keeping part ... you're the guy fixing the bugs and
merging them into the release branches :)
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: [jira] Updated: (LUCENE-1198) Exception in DocumentsWriter.ThreadState.init leads to corruption
Posted by Michael McCandless <lu...@mikemccandless.com>.
Thanks Hoss!
Mike
On Mar 11, 2008, at 3:28 PM, Hoss Man (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/LUCENE-1198?
> page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Hoss Man updated LUCENE-1198:
> -----------------------------
>
> Fix Version/s: 2.3.2
>
> targeted for 2.3.2 bug fix release
>
>> Exception in DocumentsWriter.ThreadState.init leads to corruption
>> -----------------------------------------------------------------
>>
>> Key: LUCENE-1198
>> URL: https://issues.apache.org/jira/browse/
>> LUCENE-1198
>> Project: Lucene - Java
>> Issue Type: Bug
>> Components: Index
>> Affects Versions: 2.3
>> Reporter: Michael McCandless
>> Assignee: Michael McCandless
>> Priority: Minor
>> Fix For: 2.3.2, 2.4
>>
>> Attachments: LUCENE-1198.patch
>>
>>
>> If an exception is hit in the init method, DocumentsWriter
>> incorrectly
>> increments numDocsInRAM when in fact the document is not added.
>> Spinoff of this thread:
>> http://markmail.org/message/e76hgkgldxhakuaa
>> The root cause that led to the exception in init was actually due to
>> incorrect use of Lucene's APIs (one thread still modifying the
>> Document while IndexWriter.addDocument is adding it) but still we
>> should protect against any exceptions coming out of init.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1198) Exception in
DocumentsWriter.ThreadState.init leads to corruption
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated LUCENE-1198:
-----------------------------
Fix Version/s: 2.3.2
targeted for 2.3.2 bug fix release
> Exception in DocumentsWriter.ThreadState.init leads to corruption
> -----------------------------------------------------------------
>
> Key: LUCENE-1198
> URL: https://issues.apache.org/jira/browse/LUCENE-1198
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.3
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.3.2, 2.4
>
> Attachments: LUCENE-1198.patch
>
>
> If an exception is hit in the init method, DocumentsWriter incorrectly
> increments numDocsInRAM when in fact the document is not added.
> Spinoff of this thread:
> http://markmail.org/message/e76hgkgldxhakuaa
> The root cause that led to the exception in init was actually due to
> incorrect use of Lucene's APIs (one thread still modifying the
> Document while IndexWriter.addDocument is adding it) but still we
> should protect against any exceptions coming out of init.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1198) Exception in
DocumentsWriter.ThreadState.init leads to corruption
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1198.
----------------------------------------
Resolution: Fixed
> Exception in DocumentsWriter.ThreadState.init leads to corruption
> -----------------------------------------------------------------
>
> Key: LUCENE-1198
> URL: https://issues.apache.org/jira/browse/LUCENE-1198
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.3
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1198.patch
>
>
> If an exception is hit in the init method, DocumentsWriter incorrectly
> increments numDocsInRAM when in fact the document is not added.
> Spinoff of this thread:
> http://markmail.org/message/e76hgkgldxhakuaa
> The root cause that led to the exception in init was actually due to
> incorrect use of Lucene's APIs (one thread still modifying the
> Document while IndexWriter.addDocument is adding it) but still we
> should protect against any exceptions coming out of init.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1198) Exception in
DocumentsWriter.ThreadState.init leads to corruption
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1198:
---------------------------------------
Attachment: LUCENE-1198.patch
Attached patch. I added a unit test showing the issue. To do this, I
added this method to IndexWriter:
boolean testPoint(String name)
Then in DocumentsWriter.ThreadState.init I added this:
assert writer.testPoint("DocumentsWriter.ThreadState.init start");
Then, tests can subclass IndexWriter and do interesting things at each
of these test points. We can add further test points over time...
Then I fixed the issue and the tests (& all tests) pass. I'll commit
in a day or two.
> Exception in DocumentsWriter.ThreadState.init leads to corruption
> -----------------------------------------------------------------
>
> Key: LUCENE-1198
> URL: https://issues.apache.org/jira/browse/LUCENE-1198
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.3
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1198.patch
>
>
> If an exception is hit in the init method, DocumentsWriter incorrectly
> increments numDocsInRAM when in fact the document is not added.
> Spinoff of this thread:
> http://markmail.org/message/e76hgkgldxhakuaa
> The root cause that led to the exception in init was actually due to
> incorrect use of Lucene's APIs (one thread still modifying the
> Document while IndexWriter.addDocument is adding it) but still we
> should protect against any exceptions coming out of init.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org