You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by rdowner <gi...@git.apache.org> on 2014/11/26 18:22:13 UTC

[GitHub] incubator-brooklyn pull request: Make binary files optional

GitHub user rdowner opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/365

    Make binary files optional

    We are unable, by Apache convention, to include binary files in our source code releases. But we are allowed to make a source release that is a subset of our Git repository. Therefore, we are able to make a source release that simply excludes binary files.
    
    These changes modify tests that rely on binary files to gracefully handle the lack of binary test resources. This is done by throwing a derivative of SkipException, which causes TestNG to mark the test as "skipped" (neither failed, nor passed)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rdowner/incubator-brooklyn binary-files-optional

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #365
    
----
commit b0bf899f30459b2b105aa0c82648b16c4d672eb2
Author: Richard Downer <ri...@apache.org>
Date:   2014-11-26T13:05:44Z

    Add TestResourceUnavailableException
    
    Provides a way to skip TestNG tests if a test resource is not available (such as in the source distribution, which does not carry binary test resources)

commit 6339b0ce4404b70604a84d94c98e47c56fce51e8
Author: Richard Downer <ri...@apache.org>
Date:   2014-11-26T13:08:09Z

    Make embedded jars optional
    
    Modifies code that relies on jar files as an embedded resource to
    gracefully handle cases where the files are missing. Limited to tests,
    which will cause TestNG to skip the test if the resource is missing.
    Required for our source distribution, as Apache convention is to not
    ship binaries in releases.

commit 74ab16d1291d03bfc203ac36a9f5b267400d7af9
Author: Richard Downer <ri...@apache.org>
Date:   2014-11-26T16:22:56Z

    Make embedded wars optional
    
    Modifies code that relies on war files as an embedded resource to
    gracefully handle cases where the files are missing. Limited to tests,
    which will cause TestNG to skip the test if the resource is missing.
    Required for our source distribution, as Apache convention is to not
    ship binaries in releases.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Make binary files optional

Posted by grkvlt <gi...@git.apache.org>.

Github user grkvlt commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/365#issuecomment-65096762
  
    Look good, but needs rebased before it can be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Make binary files optional

Posted by richardcloudsoft <gi...@git.apache.org>.

Github user richardcloudsoft commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/365#issuecomment-65097985
  
    Thanks @grkvlt - I've rebased it and will now merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Make binary files optional

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/365


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Make binary files optional

Posted by richardcloudsoft <gi...@git.apache.org>.

Github user richardcloudsoft commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/365#issuecomment-65063040
  
    Any comments on this PR? Would be good to get a decision either way and get the release process moving again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---