You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by britter <gi...@git.apache.org> on 2017/02/06 19:05:14 UTC
[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/142
SUREFIRE-1330: Import provider code donated by JUnit team
This PR adds the code donated in [SUREFIRE-1330](https://issues.apache.org/jira/browse/SUREFIRE-1330) by @marcphilipp. Here are the changes I've made after the initial import:
- Removed license file, since we ship the Apache License with our source distribution
- ASF license header
- tabs -> spaces
- Maven code style
- some clean up
Note that the unit tests in the provider module are not executed since that would require automatic lookup code for the provider itself. It may be possible to the the tests running by explicitly declaring the already released provider by the JUnit team as described in their [documentation](http://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven). I gave that a try but was unable to get it working.
We currently have no attribution for the JUnit developers or the contributors who wrote the code. We could add this to the developers section of pom.xml of the provider. @marcphilipp please let us know who we should attribute this donation to.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven-surefire SUREFIRE-1330
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit 73e09a8b2b245e76e072c1809e7fa50be02e95b6
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T13:02:48Z
SUREFIRE-1330: Import code from https://issues.apache.org/jira/browse/SUREFIRE-1330 unchanged as provided
commit 0c329812e71f149bb7c92bfaa3fa37c6d2ec6eec
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T13:20:54Z
Remove LICENSE file, ALv2 will be part of the source distribution
commit a0d0325db046f266abc401abe3e0047f6ce908c3
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T13:23:03Z
Convert spaces to tabs
commit 62d00dca5709c0a089a65f810c1c66c2897b5003
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T13:25:01Z
Use Apache Software Foundation License header
commit 9283dee30decf62e12edd5eaea08abd811ee811f
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T14:20:30Z
Adopt Apache Maven code style
commit caceca16772c6d11302c2d8627c7f5b7d913878a
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T17:55:49Z
Add surefire-junit5 provider as module to the surefire build
commit 43fb41e8d4115830fbeb6d29f1f17efe8e04de5f
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T17:56:20Z
Remove unused filed
commit 30ee7b94c3421411aa6257e78f77fe8b88aa125e
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T18:06:23Z
Remove usage of internal JUnit API
commit c197b926a5f02ab2a3842d4a8a736315c3c8eb33
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T18:14:53Z
Move provider classes to maven surefire package
commit 97f97167ea0aa07bba4bd864b1f686c2f79ca33d
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T18:17:36Z
Remove engine declaration - this should be done automatically by surefire
commit b08b1aeae4ad01582fd6264462a4a9345bfd065d
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T18:54:40Z
Make Checkstyle happy
commit ef6a391006ab1fa672dc26fc234b6411a7dfa888
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-02-06T18:54:59Z
Configure shade plugin so that is does not explode
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/142
Thank you! I will continue then with the detection code in ABstractSurefireMojo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@Tibor17 this PR is for 3.0-rc1 branch not for master. Can't we integrate it into 3.0-rc1 branch right away?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by mgreau <gi...@git.apache.org>.
Github user mgreau commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@britter Hi FYI I have create a PR (#146) to finalize the updates proposed by @marcphilipp
At @exoplatform we are working on UI automation tests with Maven JUnit5 and Selenide, so let me know how I can help on the maven-surefire:3.0.0 version \U0001f609
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by marcphilipp <gi...@git.apache.org>.
Github user marcphilipp commented on the issue:
https://github.com/apache/maven-surefire/pull/142
> It may be possible to the the tests running by explicitly declaring the already released provider by the JUnit team as described in their documentation. I gave that a try but was unable to get it working.
Did you change the include pattern? I think Surefire only not pickup `*Tests` by default (see http://maven.apache.org/components/surefire/maven-surefire-plugin/test-mojo.html#includes).
> @marcphilipp please let us know who we should attribute this donation to.
Please use the list in junit-team/junit5#541. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@britter
Sure I will do it, no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by sbrannen <gi...@git.apache.org>.
Github user sbrannen commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@marcphilipp, 2.19.2 will support "*Tests" by default as well:
https://twitter.com/sam_brannen/status/766979129954570240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/142
Resolved comments by @marcphilipp
WDYT @Tibor17? Looks good for merge? behavior of surefire is currently not changed since we don't have automatic look up code. Would like to implement this on a separate branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@sbrannen
It looks like we will rename 2.19.2 to 2.20.0, but this is not official yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by sbrannen <gi...@git.apache.org>.
Github user sbrannen commented on the issue:
https://github.com/apache/maven-surefire/pull/142
Very happy to hear that the Surefire team has taken over the provider for the JUnit Platform!!!
Thanks! \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@britter
LGTM
We have to wait for release 2.19.2.
After that I will squash previous changes into one and commit to master which will be 3.0 RC1.
Meanwhile we can continue on both branches, means this 3.0-rc1 and junit5 integration tests.
I am pushed two other branches which were reverted before and one more is pending. So I am in progress as well and I hope the Maven colleagues would give me go-ahead and finalize release 2.19.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...
Posted by marcphilipp <gi...@git.apache.org>.
Github user marcphilipp commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/142#discussion_r99669653
--- Diff: surefire-providers/pom.xml ---
@@ -41,6 +41,7 @@
<module>surefire-junit3</module>
<module>surefire-junit4</module>
<module>surefire-junit47</module>
+ <module>surefire-junit5</module>
--- End diff --
I think surefire-junit-platform would be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/142
awesome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...
Posted by sbrannen <gi...@git.apache.org>.
Github user sbrannen commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/142#discussion_r101716366
--- Diff: surefire-providers/pom.xml ---
@@ -41,6 +41,7 @@
<module>surefire-junit3</module>
<module>surefire-junit4</module>
<module>surefire-junit47</module>
+ <module>surefire-junit5</module>
--- End diff --
Agreed. Please do not refer to the _JUnit Platform_ as "JUnit 5".
The JUnit Platform is approaching version 1.0 GA, not 5.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven-surefire/pull/142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@britter
@marcphilipp
Done. We are preparing a new release version of Maven and Surefire was examined last days. We still investigate some issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...
Posted by marcphilipp <gi...@git.apache.org>.
Github user marcphilipp commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/142#discussion_r99669961
--- Diff: surefire-providers/surefire-junit5/src/main/resources/META-INF/services/org.apache.maven.surefire.providerapi.SurefireProvider ---
@@ -0,0 +1 @@
+org.apache.maven.surefire.junit5.JUnitPlatformProvider
--- End diff --
`org.apache.maven.surefire.junitplatform` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org