You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/02/24 16:23:38 UTC

[GitHub] [maven-surefire] mpkorstanje commented on a change in pull request #338: Upgrade Cucumber versions

mpkorstanje commented on a change in pull request #338:
URL: https://github.com/apache/maven-surefire/pull/338#discussion_r582103047



##########
File path: surefire-its/src/test/resources/junit47-cucumber/pom.xml
##########
@@ -34,8 +34,7 @@
   <name>Tests cucumber with JUnit47 provider</name>
 
   <properties>
-    <cucumber.version>1.1.3</cucumber.version>
-    <junit.version>4.11</junit.version>

Review comment:
       JUnit is a transitive dependency of cucumber-junit

##########
File path: surefire-its/src/test/resources/junit47-rerun-failing-tests-with-cucumber/pom.xml
##########
@@ -57,12 +57,6 @@
     </build>
 
     <dependencies>
-        <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>

Review comment:
       JUnit is a transitive dependency of cucumber-junit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org