[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1104: Change: DON'T check root exist if pass root token

[GitBox <gi...@apache.org>]

little-cui commented on a change in pull request #1104:
URL: https://github.com/apache/servicecomb-service-center/pull/1104#discussion_r676010021



##########
File path: server/service/rbac/authr_plugin.go
##########
@@ -102,19 +99,6 @@ func (a *EmbeddedAuthenticator) Authenticate(ctx context.Context, tokenStr strin
 		}
 		return nil, err
 	}
-	accountNameI := claims[rbac.ClaimsUser]
-	n, ok := accountNameI.(string)
-	if !ok {
-		return nil, rbac.ErrConvert
-	}
-	exist, err := datasource.GetAccountManager().AccountExist(ctx, n)

Review comment:
       并没有删除，只是这个函数是解析jwt的claims信息，我觉得把账号存在性耦合不合适，单独抽离到server/plugin/auth/buildin/buildin.go:73




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org