You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2015/10/13 03:50:36 UTC
[24/50] logging-log4j2 git commit: LOG4J2-935: document reason for
this logic in comments
LOG4J2-935: document reason for this logic in comments
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/df69b3fb
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/df69b3fb
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/df69b3fb
Branch: refs/heads/LOG4J2-1136
Commit: df69b3fb81b0c22d4700b0fbcc91dbcca039d07d
Parents: 3f9740b
Author: rpopma <rp...@apache.org>
Authored: Mon Oct 5 02:00:43 2015 +0200
Committer: rpopma <rp...@apache.org>
Committed: Mon Oct 5 02:00:43 2015 +0200
----------------------------------------------------------------------
.../apache/logging/log4j/core/layout/AbstractStringLayout.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/df69b3fb/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
index 3a5d39b..de73e27 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
@@ -63,7 +63,7 @@ public abstract class AbstractStringLayout extends AbstractLayout<String> {
static byte[] toBytes(final String str, final Charset charset) {
if (str != null) {
final Charset actual = charset != null ? charset : Charset.defaultCharset();
- try {
+ try { // LOG4J2-935: String.getBytes(String) gives better performance
return str.getBytes(actual.name());
} catch (UnsupportedEncodingException e) {
return str.getBytes(actual);
@@ -88,7 +88,7 @@ public abstract class AbstractStringLayout extends AbstractLayout<String> {
}
protected byte[] getBytes(final String s) {
- try {
+ try { // LOG4J2-935: String.getBytes(String) gives better performance
return s.getBytes(charsetName);
} catch (UnsupportedEncodingException e) {
return s.getBytes(charset);