You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/07 22:20:06 UTC
[GitHub] [airflow] avkirilishin opened a new pull request #21404: EdgeModifier refactoring
avkirilishin opened a new pull request #21404:
URL: https://github.com/apache/airflow/pull/21404
closes: #17469
| Dag | Before | After |
| ------------- | ------------- | ------------- |
| simple_label | <img width="231" alt="image" src="https://user-images.githubusercontent.com/54231417/152872227-3857a811-1c7d-4efc-9e06-180024f2245d.png"> | <img width="342" alt="image" src="https://user-images.githubusercontent.com/54231417/152867781-6de7552b-a9fa-4564-a2a7-0db9529ae155.png"> |
| simple_label_reversed | <img width="231" alt="image" src="https://user-images.githubusercontent.com/54231417/152872356-a8c3447e-2b2d-41be-8938-a716d6226b03.png"> | <img width="338" alt="image" src="https://user-images.githubusercontent.com/54231417/152867702-b61ef838-bd1b-4160-8cae-a514ce029cab.png"> |
| complex_label | <img height="500" alt="image" src="https://user-images.githubusercontent.com/54231417/152872508-e78eebf0-c0ca-4960-ba2b-a1454c9b4aca.png"> | <img height="500" alt="image" src="https://user-images.githubusercontent.com/54231417/152865925-5b25d205-591b-4065-9127-eb15aa44d360.png"> |
Tested on dags:
[test_label_refactoring.py.zip](https://github.com/avkirilishin/airflow/files/8018631/test_label_refactoring.py.zip)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1040181242
@avkirilishin - would it be possible to add some unit tests for this one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1040180602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21404:
URL: https://github.com/apache/airflow/pull/21404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] avkirilishin commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
avkirilishin commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1045220480
> Also good for me so @avkirilishin -> adding some testswill be great.
@potiuk Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1040180602
I think this one needs a deeper look @bbovenzi @kaxil - I think you asked for a fix in #17469 and it LOOKS like a good fix. Which (if confirmed) might even qualify for 2.2.4 release @jedcunningham ? (marked it provisionally).
I do not know that well about EdgeModifiers and relations setting but it does look legit from first point of view. And I think possibly some unit tests here woudl be useful. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] avkirilishin commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
avkirilishin commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1040599467
> would it be possible to add some unit tests for this one?
I am ready to add some unit tests if the approach is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1044549265
Also good for me so @avkirilishin -> adding some testswill be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1046274164
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1055438366
Rebasing to see if issues are fixed (should be by MS).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1055533590
Jsut a temporary error that needs to be handled separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] avkirilishin commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
avkirilishin commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1040599467
> would it be possible to add some unit tests for this one?
I am ready to add some unit tests if the approach is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1040180602
I think this one needs a deeper look @bbovenzi @kaxil - I think you asked for a fix in #17469 and it LOOKS like a good fix. Which (if confirmed) might even qualify for 2.2.4 release @jedcunningham ? (marked it provisionally).
I do not know that well about EdgeModifiers and relations setting but it does look legit from first look.
And I think possibly some unit tests here woudl be useful. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1040180602
I think this one needs a deeper look @bbovenzi @kaxil - I think you asked for a fix in #17469 and it LOOKS like a good fix. Which (if confirmed) might even qualify for 2.2.4 release @jedcunningham ? (marked it provisionally).
I do not know that well about EdgeModifiers and relations setting but it does look legit from first look.
And I think possibly some unit tests here woudl be useful. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1040626825
Yeah, I would say we should move forward with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #21404: EdgeModifier refactoring
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #21404:
URL: https://github.com/apache/airflow/pull/21404#issuecomment-1040626825
Yeah, I would say we should move forward with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org