You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Shawn Jiang <ge...@gmail.com> on 2011/01/07 07:08:11 UTC
Does it needed to deploy single annotated Type if there's no
annotation in the impl Class ?
I met some CNF problem when running full profile Geronimo TCK. I traced
the problem and found even there's no annoation at all in implClass.
deploySingleAnnoatedType() will still get executed and scan all the field of
the implClass. See following code in method:
org.apache.webbeans.config.BeansDeployer.deployFromClassPath(ScannerService)
...
AnnotatedType<?> annotatedType =
webBeansContext.getAnnotatedElementFactory().newAnnotatedType(implClass);
if (null != annotatedType)
{
deploySingleAnnotatedType(implClass, annotatedType);
}
...
I'm wondering if the condition should be something like this:
if (null != annotatedType*&&annotatedType.getAnnotations().size()>0*)
{
deploySingleAnnotatedType(implClass, annotatedType);
}
Any comments ?
--
Shawn
Re: Does it needed to deploy single annotated Type if there's no
annotation in the impl Class ?
Posted by Shawn Jiang <ge...@gmail.com>.
Thanks David,
Right there's no such error in current AHP report because It's found
when I'm running tck against the jax-rs integration code locally.
On Fri, Jan 7, 2011 at 3:02 PM, David Jencks <da...@yahoo.com> wrote:
> Hi Shawn,
>
> I think there are several situations where a class with no annotations can
> still be a web bean. I'm not very familiar with these but I think one case
> is when there's an annotated Producer method that returns an instance of the
> class.
>
> David Blevins improved the xbean-finder so that it can figure out all the
> classes OWB needs to look at in the (geronimo, osgi) scanner service. I
> think that once we integrate this improvement the CNF problem will be
> solved.
>
> I don't recall seeing this problem in the parts of the tck I ran, could you
> ping the g. tck list with some details?
>
> thanks
> david jencks
>
> On Jan 6, 2011, at 10:08 PM, Shawn Jiang wrote:
>
> > I met some CNF problem when running full profile Geronimo TCK. I traced
> > the problem and found even there's no annoation at all in implClass.
> > deploySingleAnnoatedType() will still get executed and scan all the field
> of
> > the implClass. See following code in method:
> >
> >
> org.apache.webbeans.config.BeansDeployer.deployFromClassPath(ScannerService)
> >
> > ...
> >
> > AnnotatedType<?> annotatedType =
> > webBeansContext.getAnnotatedElementFactory().newAnnotatedType(implClass);
> >
> > if (null != annotatedType)
> > {
> > deploySingleAnnotatedType(implClass, annotatedType);
> > }
> >
> > ...
> >
> >
> >
> > I'm wondering if the condition should be something like this:
> >
> >
> > if (null != annotatedType*&&annotatedType.getAnnotations().size()>0*)
> > {
> > deploySingleAnnotatedType(implClass, annotatedType);
> > }
> >
> >
> >
> > Any comments ?
> > --
> > Shawn
>
>
--
Shawn
Re: Does it needed to deploy single annotated Type if there's no annotation in the impl Class ?
Posted by David Jencks <da...@yahoo.com>.
Hi Shawn,
I think there are several situations where a class with no annotations can still be a web bean. I'm not very familiar with these but I think one case is when there's an annotated Producer method that returns an instance of the class.
David Blevins improved the xbean-finder so that it can figure out all the classes OWB needs to look at in the (geronimo, osgi) scanner service. I think that once we integrate this improvement the CNF problem will be solved.
I don't recall seeing this problem in the parts of the tck I ran, could you ping the g. tck list with some details?
thanks
david jencks
On Jan 6, 2011, at 10:08 PM, Shawn Jiang wrote:
> I met some CNF problem when running full profile Geronimo TCK. I traced
> the problem and found even there's no annoation at all in implClass.
> deploySingleAnnoatedType() will still get executed and scan all the field of
> the implClass. See following code in method:
>
> org.apache.webbeans.config.BeansDeployer.deployFromClassPath(ScannerService)
>
> ...
>
> AnnotatedType<?> annotatedType =
> webBeansContext.getAnnotatedElementFactory().newAnnotatedType(implClass);
>
> if (null != annotatedType)
> {
> deploySingleAnnotatedType(implClass, annotatedType);
> }
>
> ...
>
>
>
> I'm wondering if the condition should be something like this:
>
>
> if (null != annotatedType*&&annotatedType.getAnnotations().size()>0*)
> {
> deploySingleAnnotatedType(implClass, annotatedType);
> }
>
>
>
> Any comments ?
> --
> Shawn