[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615209#comment-17615209 ] 

ASF GitHub Bot commented on HADOOP-18487:
-----------------------------------------

steveloughran opened a new pull request, #4996:
URL: https://github.com/apache/hadoop/pull/4996

   
   The option protobuf.scope defines whether the protobuf 2.5.0 dependency is marked as provided or not.
   
   * all declarations except those in yarn-csi are updated
   * those modules which don't compile without their own explicit import (hadoop-hdfs-client, hadoop-hdfs-rbf)
   
   It's actually interesting to see where/how that compile fails
   
   hadoop-hdfs-client: ClientNamenodeProtocolTranslatorPB hadoop-hdfs-rbf:RouterAdminProtocolTranslatorPB
   
   both with "class file for com.google.protobuf.ServiceException not found", even though *neither class uses it*
   
   what they do have is references to ProtobufHelper.getRemoteException(), which is overloaded to both the shaded ServiceException and the original one
   
   Hypothesis: the javac overload resolution needs to look at the entire class hierarchy before it can decide which one to use.
   
   Proposed: add a new method
    ioe extractException(org.apache.hadoop.thirdparty.protobuf.ServiceException)
   and move our own code to it. Without the overloading the classes should not be needed
   
   Change-Id: I70354abfe3f1fdc03c418dac88e60f8cc4929a33
   
   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   
   
   ### How was this patch tested?
   
   local compile, now looking at yetus runs
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> protobuf-2.5.0 dependencies => provided
> ---------------------------------------
>
>                 Key: HADOOP-18487
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18487
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, ipc
>    Affects Versions: 3.3.4
>            Reporter: Steve Loughran
>            Priority: Major
>
> uses of protobuf 2.5 and RpcEnginej have been deprecated since 3.3.0 in HADOOP-17046
> while still keeping those files around (for a long time...), how about we make the protobuf 2.5.0 export off hadoop common and hadoop-hdfs *provided*, rather than *compile*
> that way, if apps want it for their own apis, they have to explicitly ask for it, but at least our own scans don't break.
> i have no idea what will happen to the rest of the stack at this point, it will be "interesting" to see



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org