You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/02/24 01:43:54 UTC
[GitHub] [iceberg] zhangjun0x01 opened a new pull request #2265: Flink : add computed column support for flink
zhangjun0x01 opened a new pull request #2265:
URL: https://github.com/apache/iceberg/pull/2265
related to #2262
Use computed column has many advantages , flink had supported the function , the design doc is [here](https://cwiki.apache.org/confluence/display/FLINK/FLIP-70%3A+Flink+SQL+Computed+Column+Design) ,
I add the support for iceberg.
@rdblue @stevenzwu @openinx could you help me review it ,thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2265: Flink : add computed column support for flink
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2265:
URL: https://github.com/apache/iceberg/pull/2265#issuecomment-786276758
@zhangjun0x01, can you update the description to include what you're changing in Iceberg and why it should be done that way? I'm surprised to see changes to types in the API module so I think this warrants a clear description of why that's needed. It is really helpful to provide context for reviewers. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhangjun0x01 removed a comment on pull request #2265: Flink : add computed column support for flink
Posted by GitBox <gi...@apache.org>.
zhangjun0x01 removed a comment on pull request #2265:
URL: https://github.com/apache/iceberg/pull/2265#issuecomment-786371027
> description
@rdblue I udpated the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhangjun0x01 commented on pull request #2265: Flink : add computed column support for flink
Posted by GitBox <gi...@apache.org>.
zhangjun0x01 commented on pull request #2265:
URL: https://github.com/apache/iceberg/pull/2265#issuecomment-786371177
> @zhangjun0x01, can you update the description to include what you're changing in Iceberg and why it should be done that way? I'm surprised to see changes to types in the API module so I think this warrants a clear description of why that's needed. It is really helpful to provide context for reviewers. Thanks!
@rdblue I udpated the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhangjun0x01 commented on pull request #2265: Flink : add computed column support for flink
Posted by GitBox <gi...@apache.org>.
zhangjun0x01 commented on pull request #2265:
URL: https://github.com/apache/iceberg/pull/2265#issuecomment-786371027
> description
@rdblue I udpated the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org