You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/17 01:43:24 UTC

[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5323: [ISSUE #5322] improving SDK topic route availability

lizhanhui commented on code in PR #5323:
URL: https://github.com/apache/rocketmq/pull/5323#discussion_r996550415


##########
common/src/main/java/org/apache/rocketmq/common/namesrv/NamesrvConfig.java:
##########
@@ -78,6 +78,9 @@ public class NamesrvConfig {
      */
     private boolean enableControllerInNamesrv = false;
 
+    private volatile boolean needWaitForService = true;
+
+    private int waitSecondsForService = 45;

Review Comment:
   Hard-coded value is not optimal, users might adjust the interval of broker registration... Would it be better to set it to alpha * interval_of_broker_registration, where alpha is somewhat 1.5 or 2?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org