You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2015/09/28 14:48:52 UTC
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/
-----------------------------------------------------------
(Updated Sept. 28, 2015, 12:48 p.m.)
Review request for Ambari and Alejandro Fernandez.
Summary (updated)
-----------------
AMBARI-13242: ambari-server setup failed if use another server as ambari-server next time
Bugs: AMBARI-13242
https://issues.apache.org/jira/browse/AMBARI-13242
Repository: ambari
Description
-------
The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
File "/usr/sbin/ambari-server.py", line 26, in <module>
from ambari_commons.exceptions import FatalException, NonFatalException
File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
Diffs
-----
ambari-agent/pom.xml 0096162
ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
ambari-server/pom.xml 3377961
ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
Diff: https://reviews.apache.org/r/38806/diff/
Testing
-------
Generate Ambari Server and Agent RPMs
Install the Ambari Agent RPM on a machine
Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
Thanks,
Di Li
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 2, 2015, 8:36 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/package/rpm/postremove.sh, line 27
> > <https://reviews.apache.org/r/38806/diff/2/?file=1088749#file1088749line27>
> >
> > My suggestion here is that this type of logic may lead to bugs in the future, once we support a higher version of python, because ambari python wrap has its own logic for picking the python version.
> >
> > Python isn't necessarily guaranteed to be in that location, so ideally we would either
> > A. Iterate over all of the versions of python installed and attempt to delete these ambari folders
> >
> > Or
> >
> > B. Share the same logic that calculates which python version to use, and call it from this script.
> >
> > This is something that requires testing on non-default paths of Python, and also multiple python versions installed. E.g., only 2.6, only 2.7, or both.
>
> Andrew Onischuk wrote:
> Alejandro, we already support python 2.7 but still we use /usr/lib/python2.6/site-packages directory to store/execute ambari-agent python scripts independent of the python version. That's why this code is fine IMO.
>
> Alejandro Fernandez wrote:
> Let's add some comments to the code in both this file and ambari-python-wrap that they are hardcoding python 2.6
I added two comments to the postunintall.sh for server and agent to explain why use hardcoded python2.6 location.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101370
-----------------------------------------------------------
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Oct. 2, 2015, 8:36 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/package/rpm/postremove.sh, line 27
> > <https://reviews.apache.org/r/38806/diff/2/?file=1088749#file1088749line27>
> >
> > My suggestion here is that this type of logic may lead to bugs in the future, once we support a higher version of python, because ambari python wrap has its own logic for picking the python version.
> >
> > Python isn't necessarily guaranteed to be in that location, so ideally we would either
> > A. Iterate over all of the versions of python installed and attempt to delete these ambari folders
> >
> > Or
> >
> > B. Share the same logic that calculates which python version to use, and call it from this script.
> >
> > This is something that requires testing on non-default paths of Python, and also multiple python versions installed. E.g., only 2.6, only 2.7, or both.
>
> Andrew Onischuk wrote:
> Alejandro, we already support python 2.7 but still we use /usr/lib/python2.6/site-packages directory to store/execute ambari-agent python scripts independent of the python version. That's why this code is fine IMO.
Let's add some comments to the code in both this file and ambari-python-wrap that they are hardcoding python 2.6
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101370
-----------------------------------------------------------
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Oct. 2, 2015, 8:36 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/package/rpm/postremove.sh, line 27
> > <https://reviews.apache.org/r/38806/diff/2/?file=1088749#file1088749line27>
> >
> > My suggestion here is that this type of logic may lead to bugs in the future, once we support a higher version of python, because ambari python wrap has its own logic for picking the python version.
> >
> > Python isn't necessarily guaranteed to be in that location, so ideally we would either
> > A. Iterate over all of the versions of python installed and attempt to delete these ambari folders
> >
> > Or
> >
> > B. Share the same logic that calculates which python version to use, and call it from this script.
> >
> > This is something that requires testing on non-default paths of Python, and also multiple python versions installed. E.g., only 2.6, only 2.7, or both.
Alejandro, we already support python 2.7 but still we use /usr/lib/python2.6/site-packages directory to store/execute ambari-agent python scripts independent of the python version. That's why this code is fine IMO.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101370
-----------------------------------------------------------
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101370
-----------------------------------------------------------
ambari-agent/src/main/package/rpm/postremove.sh (line 27)
<https://reviews.apache.org/r/38806/#comment158735>
My suggestion here is that this type of logic may lead to bugs in the future, once we support a higher version of python, because ambari python wrap has its own logic for picking the python version.
Python isn't necessarily guaranteed to be in that location, so ideally we would either
A. Iterate over all of the versions of python installed and attempt to delete these ambari folders
Or
B. Share the same logic that calculates which python version to use, and call it from this script.
This is something that requires testing on non-default paths of Python, and also multiple python versions installed. E.g., only 2.6, only 2.7, or both.
- Alejandro Fernandez
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 2, 2015, 7:56 p.m., Sid Wagle wrote:
> > ambari-server/src/main/package/rpm/postremove.sh, line 24
> > <https://reviews.apache.org/r/38806/diff/2/?file=1088751#file1088751line24>
> >
> > I do not think it is customary to remove logs on rpm remove.
hello Sid,
I left the dirs out of the removal logic.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101362
-----------------------------------------------------------
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101362
-----------------------------------------------------------
ambari-server/src/main/package/rpm/postremove.sh (line 24)
<https://reviews.apache.org/r/38806/#comment158730>
I do not think it is customary to remove logs on rpm remove.
- Sid Wagle
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 2, 2015, 7:37 p.m., Andrew Onischuk wrote:
> > ambari-server/pom.xml, line 285
> > <https://reviews.apache.org/r/38806/diff/2/?file=1088750#file1088750line285>
> >
> > Here we only fix the link issue with rpm, but on debian it still exists, shouldn't we add this there as well.
> >
> > Maybe with moving the code to install-helper.sh.
> >
> > To avoid duplication
moved most of the remove logic to the install-helper.py as they can be done during the preun stage.
> On Oct. 2, 2015, 7:37 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/package/rpm/postremove.sh, line 24
> > <https://reviews.apache.org/r/38806/diff/2/?file=1088751#file1088751line24>
> >
> > I understand when we delete links, but why are we deleting this folders. Sholdn't they get deleted automatically on deleting RPM?
left dirs alone
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101356
-----------------------------------------------------------
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101356
-----------------------------------------------------------
ambari-server/pom.xml (line 285)
<https://reviews.apache.org/r/38806/#comment158725>
Here we only fix the link issue with rpm, but on debian it still exists, shouldn't we add this there as well.
Maybe with moving the code to install-helper.sh.
To avoid duplication
ambari-server/src/main/package/rpm/postremove.sh (line 24)
<https://reviews.apache.org/r/38806/#comment158724>
I understand when we delete links, but why are we deleting this folders. Sholdn't they get deleted automatically on deleting RPM?
- Andrew Onischuk
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Oct. 5, 2015, 3:44 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/package/rpm/postremove.sh, line 25
> > <https://reviews.apache.org/r/38806/diff/4/?file=1091077#file1091077line25>
> >
> > The same question for server. Why do we delete this folder.
> >
> > Shouldn't rpm automatically do that?
>
> Di Li wrote:
> Hello Andrew,
>
> RPM is not removing the ambari_server dir from python2.6/site-packages. I found that the ambari-server dir was left there with 16 pyc files in it. So my think is that I should try to remove it in the postun script.
>
> P.S
> RPM does remove ambari_agent dir from python2.6/sites-packages.
Can we do the same fix for debian/ubuntu? (maybe by moving to install-helper.sh)
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101482
-----------------------------------------------------------
On Oct. 5, 2015, 3:37 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 3:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
> ambari-server/pom.xml 83f39ec
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 5, 2015, 3:44 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/package/rpm/postremove.sh, line 25
> > <https://reviews.apache.org/r/38806/diff/4/?file=1091077#file1091077line25>
> >
> > The same question for server. Why do we delete this folder.
> >
> > Shouldn't rpm automatically do that?
>
> Di Li wrote:
> Hello Andrew,
>
> RPM is not removing the ambari_server dir from python2.6/site-packages. I found that the ambari-server dir was left there with 16 pyc files in it. So my think is that I should try to remove it in the postun script.
>
> P.S
> RPM does remove ambari_agent dir from python2.6/sites-packages.
>
> Andrew Onischuk wrote:
> Can we do the same fix for debian/ubuntu? (maybe by moving to install-helper.sh)
Hello Andrew,
I just moved the removing ambari_server from python2.6/site-packages logic from ambari server's postun script to the install-helper.sh.
The change also removes the need of having postun for ambari server.
Please review.
Thanks.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101482
-----------------------------------------------------------
On Oct. 5, 2015, 3:37 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 3:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
> ambari-server/pom.xml 83f39ec
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 5, 2015, 3:44 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/package/rpm/postremove.sh, line 25
> > <https://reviews.apache.org/r/38806/diff/4/?file=1091077#file1091077line25>
> >
> > The same question for server. Why do we delete this folder.
> >
> > Shouldn't rpm automatically do that?
Hello Andrew,
RPM is not removing the ambari_server dir from python2.6/site-packages. I found that the ambari-server dir was left there with 16 pyc files in it. So my think is that I should try to remove it in the postun script.
P.S
RPM does remove ambari_agent dir from python2.6/sites-packages.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101482
-----------------------------------------------------------
On Oct. 5, 2015, 3:37 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 3:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
> ambari-server/pom.xml 83f39ec
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101482
-----------------------------------------------------------
ambari-server/src/main/package/rpm/postremove.sh (line 25)
<https://reviews.apache.org/r/38806/#comment158886>
The same question for server. Why do we delete this folder.
Shouldn't rpm automatically do that?
- Andrew Onischuk
On Oct. 5, 2015, 3:37 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 3:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
> ambari-server/pom.xml 83f39ec
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Oct. 5, 2015, 8:05 p.m., Andrew Onischuk wrote:
> > ambari-server/conf/unix/install-helper.sh, line 52
> > <https://reviews.apache.org/r/38806/diff/5/?file=1091197#file1091197line52>
> >
> > There is a typo, rather than that looks good.
>
> Di Li wrote:
> Hello Andrew,
>
> Thanks for the review. please find the latest patched uploaded (Revision 7) with the typo fixed. Please ignore Revision 6 of the Diff as it's a bad upload. Please use Revision 7 as the one with the type fix.
>
> Thanks.
Thanks for you efforts in fixing all this things :) I shipped it.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101515
-----------------------------------------------------------
On Oct. 5, 2015, 8:17 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8:17 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 5, 2015, 8:05 p.m., Andrew Onischuk wrote:
> > ambari-server/conf/unix/install-helper.sh, line 52
> > <https://reviews.apache.org/r/38806/diff/5/?file=1091197#file1091197line52>
> >
> > There is a typo, rather than that looks good.
Hello Andrew,
Thanks for the review. please find the latest patched uploaded (Revision 7) with the typo fixed. Please ignore Revision 6 of the Diff as it's a bad upload. Please use Revision 7 as the one with the type fix.
Thanks.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101515
-----------------------------------------------------------
On Oct. 5, 2015, 8:17 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8:17 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101515
-----------------------------------------------------------
ambari-server/conf/unix/install-helper.sh (line 52)
<https://reviews.apache.org/r/38806/#comment158940>
There is a typo, rather than that looks good.
- Andrew Onischuk
On Oct. 5, 2015, 7:41 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 7:41 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 5, 2015, 8:19 p.m., Andrew Onischuk wrote:
> > Ship It!
Thank Andrew. Sorry to bother you again but could you please help push the change to trunk whenever you have time?
I am not a commiter so I can't really push it in by myself.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101516
-----------------------------------------------------------
On Oct. 5, 2015, 8:17 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8:17 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Oct. 5, 2015, 8:19 p.m., Andrew Onischuk wrote:
> > Ship It!
>
> Di Li wrote:
> Thank Andrew. Sorry to bother you again but could you please help push the change to trunk whenever you have time?
> I am not a commiter so I can't really push it in by myself.
Done. You can close the reviewboard now.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101516
-----------------------------------------------------------
On Oct. 5, 2015, 8:17 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8:17 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 5, 2015, 8:19 p.m., Andrew Onischuk wrote:
> > Ship It!
>
> Di Li wrote:
> Thank Andrew. Sorry to bother you again but could you please help push the change to trunk whenever you have time?
> I am not a commiter so I can't really push it in by myself.
>
> Andrew Onischuk wrote:
> Done. You can close the reviewboard now.
Great. Thanks Andrew.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101516
-----------------------------------------------------------
On Oct. 5, 2015, 8:17 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8:17 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101516
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Oct. 5, 2015, 8:17 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8:17 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 8:17 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
Changes
-------
uploaded the patch with the typo fixed
Bugs: AMBARI-13242
https://issues.apache.org/jira/browse/AMBARI-13242
Repository: ambari
Description
-------
The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
File "/usr/sbin/ambari-server.py", line 26, in <module>
from ambari_commons.exceptions import FatalException, NonFatalException
File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
Diffs (updated)
-----
ambari-agent/conf/unix/install-helper.sh 35c67fb
ambari-server/conf/unix/install-helper.sh 9dbb2b8
Diff: https://reviews.apache.org/r/38806/diff/
Testing
-------
Generate Ambari Server and Agent RPMs
Install the Ambari Agent RPM on a machine
Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
Thanks,
Di Li
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 8:13 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
Bugs: AMBARI-13242
https://issues.apache.org/jira/browse/AMBARI-13242
Repository: ambari
Description
-------
The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
File "/usr/sbin/ambari-server.py", line 26, in <module>
from ambari_commons.exceptions import FatalException, NonFatalException
File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
Diffs (updated)
-----
ambari-agent/conf/unix/install-helper.sh 35c67fb
ambari-server/conf/unix/install-helper.sh 9dbb2b8
Diff: https://reviews.apache.org/r/38806/diff/
Testing
-------
Generate Ambari Server and Agent RPMs
Install the Ambari Agent RPM on a machine
Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
Thanks,
Di Li
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 7:41 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
Bugs: AMBARI-13242
https://issues.apache.org/jira/browse/AMBARI-13242
Repository: ambari
Description
-------
The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
File "/usr/sbin/ambari-server.py", line 26, in <module>
from ambari_commons.exceptions import FatalException, NonFatalException
File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
Diffs (updated)
-----
ambari-agent/conf/unix/install-helper.sh 35c67fb
ambari-server/conf/unix/install-helper.sh 9dbb2b8
Diff: https://reviews.apache.org/r/38806/diff/
Testing
-------
Generate Ambari Server and Agent RPMs
Install the Ambari Agent RPM on a machine
Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
Thanks,
Di Li
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 3:37 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
Bugs: AMBARI-13242
https://issues.apache.org/jira/browse/AMBARI-13242
Repository: ambari
Description
-------
The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
File "/usr/sbin/ambari-server.py", line 26, in <module>
from ambari_commons.exceptions import FatalException, NonFatalException
File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
Diffs (updated)
-----
ambari-agent/conf/unix/install-helper.sh 35c67fb
ambari-server/conf/unix/install-helper.sh 9dbb2b8
ambari-server/pom.xml 83f39ec
ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
Diff: https://reviews.apache.org/r/38806/diff/
Testing
-------
Generate Ambari Server and Agent RPMs
Install the Ambari Agent RPM on a machine
Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
Thanks,
Di Li
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 2, 2015, 11:16 p.m., Andrew Onischuk wrote:
> > ambari-agent/src/main/package/rpm/postremove.sh, line 25
> > <https://reviews.apache.org/r/38806/diff/3/?file=1089135#file1089135line25>
> >
> > Di,
> >
> > Why we are deleting this directory, shouldn't it get deleted automatically with rpm deleting?-helper.sh?
Hello Andrew,
I removed the postremove.sh for agents as it's not needed anymore, since the ambari-agent dir in python2.6/site-packages is removed per rpm uninstall. For ambari-server though, I kept the postremove.sh as the ambari-server dir was left in python2.6/site-packages after the rpm removal.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101389
-----------------------------------------------------------
On Oct. 2, 2015, 10:07 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 10:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101389
-----------------------------------------------------------
ambari-agent/src/main/package/rpm/postremove.sh (line 25)
<https://reviews.apache.org/r/38806/#comment158785>
Di,
Why we are deleting this directory, shouldn't it get deleted automatically with rpm deleting?-helper.sh?
- Andrew Onischuk
On Oct. 2, 2015, 10:07 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 10:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 35c67fb
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/conf/unix/install-helper.sh 9dbb2b8
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/
-----------------------------------------------------------
(Updated Oct. 2, 2015, 10:07 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
Bugs: AMBARI-13242
https://issues.apache.org/jira/browse/AMBARI-13242
Repository: ambari
Description
-------
The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
File "/usr/sbin/ambari-server.py", line 26, in <module>
from ambari_commons.exceptions import FatalException, NonFatalException
File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
Diffs (updated)
-----
ambari-agent/conf/unix/install-helper.sh 35c67fb
ambari-agent/pom.xml 0096162
ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
ambari-server/conf/unix/install-helper.sh 9dbb2b8
ambari-server/pom.xml 3377961
ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
Diff: https://reviews.apache.org/r/38806/diff/
Testing
-------
Generate Ambari Server and Agent RPMs
Install the Ambari Agent RPM on a machine
Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
Thanks,
Di Li
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 2, 2015, 7:42 p.m., Andrew Onischuk wrote:
> > My another concern is what happens on yum upgrade and apt-get upgrade, I think this stages get executed too somewhere for old package.
> > This should be an issue.
> >
> > But it worth testing. Can you do that?
>
> Andrew Onischuk wrote:
> "This shouldn't be an issue"* is what I meant :) But let's test it anyways just to be on the safe side.
hello Andrew,
just tested this use case, my code changes seem to be working fine.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101358
-----------------------------------------------------------
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Oct. 2, 2015, 7:42 p.m., Andrew Onischuk wrote:
> > My another concern is what happens on yum upgrade and apt-get upgrade, I think this stages get executed too somewhere for old package.
> > This should be an issue.
> >
> > But it worth testing. Can you do that?
"This shouldn't be an issue"* is what I meant :) But let's test it anyways just to be on the safe side.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101358
-----------------------------------------------------------
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101358
-----------------------------------------------------------
My another concern is what happens on yum upgrade and apt-get upgrade, I think this stages get executed too somewhere for old package.
This should be an issue.
But it worth testing. Can you do that?
- Andrew Onischuk
On Oct. 1, 2015, 8:13 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/
-----------------------------------------------------------
(Updated Oct. 1, 2015, 8:13 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
Bugs: AMBARI-13242
https://issues.apache.org/jira/browse/AMBARI-13242
Repository: ambari
Description
-------
The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
File "/usr/sbin/ambari-server.py", line 26, in <module>
from ambari_commons.exceptions import FatalException, NonFatalException
File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
Diffs (updated)
-----
ambari-agent/pom.xml 0096162
ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
ambari-server/pom.xml 3377961
ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
Diff: https://reviews.apache.org/r/38806/diff/
Testing
-------
Generate Ambari Server and Agent RPMs
Install the Ambari Agent RPM on a machine
Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
Thanks,
Di Li
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Di Li <di...@ca.ibm.com>.
> On Oct. 1, 2015, 4:48 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/package/rpm/postremove.sh, line 27
> > <https://reviews.apache.org/r/38806/diff/1/?file=1085915#file1085915line27>
> >
> > This will depend on the default Python installed. However, if Ambari detects both 2.6 and 2.7, I believe it will prefer 2.6, yet this code will return the path for 2.7.
> >
> > Can you test this with Python 2.6, 2.7, and both?
> >
> > If that is indeed the case, we need to make this pick the same version of python that Ambari uses in ambari-python-wrap. We need a way for this file and ambari-python-wrap to pick the same version.
> >
> > You can also remove ambari agent from all of the versions of python installed.
postinstall script used by Ambari server and agent calls "install-helper.sh" to set up symbolic links in /usr/lib/python2.6/site-packages. The install-helper.sh script actually hard codes the site-packages location to be "/usr/lib/python2.6/site-packages". In other words, for a host with only Python 2.7, the Ambari server/agent RPM install will create /usr/lib/python2.6/site-packages and then create symbolic links in it.
Changed the postuninstall script to also use /usr/lib/python2.6/site-packages in order to be consistent.
> On Oct. 1, 2015, 4:48 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/package/rpm/postremove.sh, line 27
> > <https://reviews.apache.org/r/38806/diff/1/?file=1085917#file1085917line27>
> >
> > Same comment as above.
postinstall script used by Ambari server and agent calls "install-helper.sh" to set up symbolic links in /usr/lib/python2.6/site-packages. The install-helper.sh script actually hard codes the site-packages location to be "/usr/lib/python2.6/site-packages". In other words, for a host with only Python 2.7, the Ambari server/agent RPM install will create /usr/lib/python2.6/site-packages and then create symbolic links in it.
Changed the postuninstall script to also use /usr/lib/python2.6/site-packages in order to be consistent.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101240
-----------------------------------------------------------
On Sept. 28, 2015, 12:48 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 12:48 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
use another server as ambari-server next time
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101240
-----------------------------------------------------------
ambari-agent/src/main/package/rpm/postremove.sh (line 27)
<https://reviews.apache.org/r/38806/#comment158615>
This will depend on the default Python installed. However, if Ambari detects both 2.6 and 2.7, I believe it will prefer 2.6, yet this code will return the path for 2.7.
Can you test this with Python 2.6, 2.7, and both?
If that is indeed the case, we need to make this pick the same version of python that Ambari uses in ambari-python-wrap. We need a way for this file and ambari-python-wrap to pick the same version.
You can also remove ambari agent from all of the versions of python installed.
ambari-server/src/main/package/rpm/postremove.sh (line 27)
<https://reviews.apache.org/r/38806/#comment158616>
Same comment as above.
Please include others for review, such as Andrew Onishuk, Sid Waggle, Nate Cole, Jonathan Hurley, Dmitry Sen.
- Alejandro Fernandez
On Sept. 28, 2015, 12:48 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 12:48 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-13242
> https://issues.apache.org/jira/browse/AMBARI-13242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.
>
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 0096162
> ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION
> ambari-server/pom.xml 3377961
> ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38806/diff/
>
>
> Testing
> -------
>
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
> On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.
>
>
> Thanks,
>
> Di Li
>
>