You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "GauthamBanasandra (via GitHub)" <gi...@apache.org> on 2025/02/27 20:13:19 UTC
[PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
GauthamBanasandra opened a new pull request, #7440:
URL: https://github.com/apache/hadoop/pull/7440
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
* There was a change to upgrade Mockito to 4.11.0 in #6968.
* This broke the build on Windows in the hadoop-yarn-ui module - https://github.com/apache/hadoop/pull/6968#issuecomment-2688763321.
* Thus, we need to revert back to the previous stable version (2.18.0) of mockito for hadoop-yarn-ui.
### How was this patch tested?
Verified by building locally on Windows 11.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "GauthamBanasandra (via GitHub)" <gi...@apache.org>.
GauthamBanasandra commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2692562156
Verified that the necessary steps are passing on Windows -
https://[ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/824/artifact/out/report.html](https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/824/artifact/out/report.html)
Yetus logs - [archive.zip](https://github.com/user-attachments/files/19041797/archive.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "GauthamBanasandra (via GitHub)" <gi...@apache.org>.
GauthamBanasandra commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2692824388
> 2.18.0 is too old, why select this version, the last is 5.15.x
@zeekling I was just restoring the version back to what it was, prior to the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2692624504
> @GauthamBanasandra the CI result shows a lot of test failures, can you check if they are related. The previous ticket [HADOOP-19243](https://issues.apache.org/jira/browse/HADOOP-19243), mentioned JDK-17 as the use case, we should see if this doesn't break that.
>
> Is there a way to fix the compilation while staying on the same mockito version?
>
> cc. @slfan1989 / @steveloughran
We indeed need to upgrade HADOOP-19243. I have conducted unit tests offline, and without this PR, some unit tests will fail on JDK17. The Mockito version 4.11.0 is not very recent. After upgrading to JUnit5, we should also update the Mockito version. From a personal perspective, I believe downgrading is not a good approach.
https://mvnrepository.com/artifact/org.mockito/mockito-core.
Can we solve this problem by upgrading the version of the `wro4j-maven-plugin` ?
```
<!-- Asset minifier -->
<plugin>
<groupId>ro.isdc.wro4j</groupId>
<artifactId>wro4j-maven-plugin</artifactId>
<version>1.7.9</version>
<dependencies>
<!-- TODO: Remove this dependency after upgrading wro4j-maven-plugin to 1.8.1 or later. -->
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-inline</artifactId>
<version>4.11.0</version>
</dependency>
</dependencies>
....
```
@GauthamBanasandra Can we try upgrading the version of the `wro4j-maven-plugin`?
https://mvnrepository.com/artifact/ro.isdc.wro4j/wro4j-maven-plugin
cc: @ayushtkn @steveloughran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "GauthamBanasandra (via GitHub)" <gi...@apache.org>.
GauthamBanasandra commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2697066124
Abandoning this PR since this was fixed by #7457.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2689228397
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 32s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 37m 59s | | trunk passed |
| +1 :green_heart: | compile | 2m 6s | | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | compile | 1m 58s | | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| +1 :green_heart: | mvnsite | 0m 43s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 23s | | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| +1 :green_heart: | shadedclient | 77m 35s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 14s | | the patch passed |
| +1 :green_heart: | compile | 1m 31s | | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javac | 1m 31s | | the patch passed |
| +1 :green_heart: | compile | 1m 48s | | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| +1 :green_heart: | javac | 1m 48s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | mvnsite | 0m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 14s | | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 14s | | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| +1 :green_heart: | shadedclient | 34m 54s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 32s | | hadoop-yarn-ui in the patch passed. |
| +1 :green_heart: | asflicense | 0m 56s | | The patch does not generate ASF License warnings. |
| | | 120m 52s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7440/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7440 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint |
| uname | Linux a4ad2c884b68 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 67cd4376fdfa0b66ca41a23eb3a657b1c76c3f8f |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7440/1/testReport/ |
| Max. process+thread count | 559 (vs. ulimit of 5500) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7440/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "GauthamBanasandra (via GitHub)" <gi...@apache.org>.
GauthamBanasandra commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2692636113
> @GauthamBanasandra the CI result shows a lot of test failures, can you check if they are related. The previous ticket HADOOP-19243, mentioned JDK-17 as the use case, we should see if this doesn't break that.
>
> Is there a way to fix the compilation while staying on the same mockito version?
>
> cc. @slfan1989 / @steveloughran
@ayushtkn the test failures that you're referring to are on Windows and are expected to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "zeekling (via GitHub)" <gi...@apache.org>.
zeekling commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2692744815
2.18.0 is too old, why select this version, the last is 5.15.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "GauthamBanasandra (via GitHub)" <gi...@apache.org>.
GauthamBanasandra commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2689017709
@muskan1012 I've attempted to fix the build failure by reverting the mockito version in the `hadoop-yarn-ui` module. Could you please take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2692614611
@GauthamBanasandra the CI result shows a lot of test failures, can you check if they are related. The previous ticket HADOOP-19243, mentioned JDK-17 as the use case, we should see if this doesn't break that.
Is there a way to fix the compilation while staying on the same mockito version?
cc. @slfan1989 / @steveloughran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "GauthamBanasandra (via GitHub)" <gi...@apache.org>.
GauthamBanasandra commented on PR #7440:
URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2692838194
I've tried to fix this issue by upgrading wro4j to `1.8.0` - #7457. It's building locally on Windows now.
I'll abandon this PR once we merge the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui [hadoop]
Posted by "GauthamBanasandra (via GitHub)" <gi...@apache.org>.
GauthamBanasandra closed pull request #7440: YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui
URL: https://github.com/apache/hadoop/pull/7440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org