You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (JIRA)" <ji...@apache.org> on 2011/01/12 23:10:45 UTC

[jira] Created: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Remove contention around MD5 generation in GuidGenerator
--------------------------------------------------------

                 Key: CASSANDRA-1977
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Brandon Williams
            Assignee: Brandon Williams
             Fix For: 0.7.1
         Attachments: 1977.txt

SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-1977:
----------------------------------------

    Attachment:     (was: 1977-v2.txt)

> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977-v2.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981010#action_12981010 ] 

Brandon Williams edited comment on CASSANDRA-1977 at 1/12/11 6:23 PM:
----------------------------------------------------------------------

v2 calls reset() before digest()

      was (Author: brandon.williams):
    v2 calls rest() before digest()
  
> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977-v2.txt, 1977.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-1977:
----------------------------------------

    Attachment: 1977-v2.txt

v2 calls rest() before digest()

> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977-v2.txt, 1977.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-1977:
----------------------------------------

           Component/s: Core
              Priority: Minor  (was: Major)
    Remaining Estimate: 1h
     Original Estimate: 1h

> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983389#action_12983389 ] 

Pavel Yaskevich commented on CASSANDRA-1977:
--------------------------------------------

+1

> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977-v2.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-1977:
----------------------------------------

    Attachment: 1977.txt

Patch removes SMD and uses a threadlocal MessageDigest in GG.

> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 0.7.1
>
>         Attachments: 1977.txt
>
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981007#action_12981007 ] 

Jonathan Ellis commented on CASSANDRA-1977:
-------------------------------------------

from the javadoc, it looks like you need to call reset() before digest().

> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983424#action_12983424 ] 

Hudson commented on CASSANDRA-1977:
-----------------------------------

Integrated in Cassandra-0.7 #173 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/173/])
    Remove contention around MD5 generation in GuidGenerator.
Patch by brandonwilliams, reviewed by Pavel Yaskevich for CASSANDRA-1977


> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977-v2.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-1977:
----------------------------------------

    Attachment: 1977-v2.txt

> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977-v2.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams resolved CASSANDRA-1977.
-----------------------------------------

    Resolution: Fixed

Committed.

> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977-v2.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1977) Remove contention around MD5 generation in GuidGenerator

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-1977:
----------------------------------------

    Attachment:     (was: 1977.txt)

> Remove contention around MD5 generation in GuidGenerator
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1977
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1977
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 1977-v2.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SafeMessageDigest is a pretty useless class too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.