You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/07/24 10:06:57 UTC
Review Request 23879: CLOUDSTACK-7127: Fix for addRegion failure,
avoiding regionid 1 while creating new region through test case
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23879/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-7127
https://issues.apache.org/jira/browse/CLOUDSTACK-7127
Repository: cloudstack-git
Description
-------
We are choosing random region id while passing it to addRegion test case. The test case failed when region id 1 was passed because the region id was already in use.
It is better to start the range from 2, as 1 will most likely be used in existing setup.
Diffs
-----
test/integration/component/test_regions.py 7b7c4a4
Diff: https://reviews.apache.org/r/23879/diff/
Testing
-------
Yes.
Log:
Test for duplicate checks on region id ... === TestName: test_createRegionWithExistingRegionId | Status : SUCCESS ===
ok
Test for duplicate checks on region name ... === TestName: test_createRegionWithExistingRegionName | Status : SUCCESS ===
ok
Test for update Region ... === TestName: test_updateRegion | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 3 tests in 2.845s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 23879: CLOUDSTACK-7127: Fix for addRegion failure,
avoiding regionid 1 while creating new region through test case
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23879/#review48654
-----------------------------------------------------------
Commit 59c77fbaa4c07e2de9578369e69f47d0e71039b8 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=59c77fb ]
CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case
- ASF Subversion and Git Services
On July 24, 2014, 2:44 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23879/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 2:44 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7127
> https://issues.apache.org/jira/browse/CLOUDSTACK-7127
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We are choosing random region id while passing it to addRegion test case. The test case failed when region id 1 was passed because the region id was already in use.
> It is better to start the range from 2, as 1 will most likely be used in existing setup.
>
>
> Diffs
> -----
>
> test/integration/component/test_regions.py 7b7c4a4
>
> Diff: https://reviews.apache.org/r/23879/diff/
>
>
> Testing
> -------
>
> Yes.
> Log:
> Test for duplicate checks on region id ... === TestName: test_createRegionWithExistingRegionId | Status : SUCCESS ===
> ok
> Test for duplicate checks on region name ... === TestName: test_createRegionWithExistingRegionName | Status : SUCCESS ===
> ok
> Test for update Region ... === TestName: test_updateRegion | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 3 tests in 2.845s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 23879: CLOUDSTACK-7127: Fix for addRegion failure,
avoiding regionid 1 while creating new region through test case
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23879/#review48655
-----------------------------------------------------------
Commit ca59f01602823a6d6fe84233f3a3d3ea499efa06 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ca59f01 ]
CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case
- ASF Subversion and Git Services
On July 24, 2014, 2:44 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23879/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 2:44 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7127
> https://issues.apache.org/jira/browse/CLOUDSTACK-7127
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We are choosing random region id while passing it to addRegion test case. The test case failed when region id 1 was passed because the region id was already in use.
> It is better to start the range from 2, as 1 will most likely be used in existing setup.
>
>
> Diffs
> -----
>
> test/integration/component/test_regions.py 7b7c4a4
>
> Diff: https://reviews.apache.org/r/23879/diff/
>
>
> Testing
> -------
>
> Yes.
> Log:
> Test for duplicate checks on region id ... === TestName: test_createRegionWithExistingRegionId | Status : SUCCESS ===
> ok
> Test for duplicate checks on region name ... === TestName: test_createRegionWithExistingRegionName | Status : SUCCESS ===
> ok
> Test for update Region ... === TestName: test_updateRegion | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 3 tests in 2.845s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 23879: CLOUDSTACK-7127: Fix for addRegion failure,
avoiding regionid 1 while creating new region through test case
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23879/#review48850
-----------------------------------------------------------
Commit d5220a88a085385ebc4b783a40f27d128ea7d28f in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d5220a8 ]
CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case
(cherry picked from commit ca59f01602823a6d6fe84233f3a3d3ea499efa06)
- ASF Subversion and Git Services
On July 24, 2014, 2:44 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23879/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 2:44 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7127
> https://issues.apache.org/jira/browse/CLOUDSTACK-7127
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We are choosing random region id while passing it to addRegion test case. The test case failed when region id 1 was passed because the region id was already in use.
> It is better to start the range from 2, as 1 will most likely be used in existing setup.
>
>
> Diffs
> -----
>
> test/integration/component/test_regions.py 7b7c4a4
>
> Diff: https://reviews.apache.org/r/23879/diff/
>
>
> Testing
> -------
>
> Yes.
> Log:
> Test for duplicate checks on region id ... === TestName: test_createRegionWithExistingRegionId | Status : SUCCESS ===
> ok
> Test for duplicate checks on region name ... === TestName: test_createRegionWithExistingRegionName | Status : SUCCESS ===
> ok
> Test for update Region ... === TestName: test_updateRegion | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 3 tests in 2.845s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 23879: CLOUDSTACK-7127: Fix for addRegion failure,
avoiding regionid 1 while creating new region through test case
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23879/
-----------------------------------------------------------
(Updated July 24, 2014, 8:14 p.m.)
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-7127
https://issues.apache.org/jira/browse/CLOUDSTACK-7127
Repository: cloudstack-git
Description
-------
We are choosing random region id while passing it to addRegion test case. The test case failed when region id 1 was passed because the region id was already in use.
It is better to start the range from 2, as 1 will most likely be used in existing setup.
Diffs
-----
test/integration/component/test_regions.py 7b7c4a4
Diff: https://reviews.apache.org/r/23879/diff/
Testing
-------
Yes.
Log:
Test for duplicate checks on region id ... === TestName: test_createRegionWithExistingRegionId | Status : SUCCESS ===
ok
Test for duplicate checks on region name ... === TestName: test_createRegionWithExistingRegionName | Status : SUCCESS ===
ok
Test for update Region ... === TestName: test_updateRegion | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 3 tests in 2.845s
OK
Thanks,
Gaurav Aradhye