You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/03 11:35:47 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1387: HDDS-4198. Compile Ozone with multiple Java versions
adoroszlai opened a new pull request #1387:
URL: https://github.com/apache/hadoop-ozone/pull/1387
## What changes were proposed in this pull request?
Compile Ozone with both Java 8 and 11 in CI.
Note: this is based on top of #1386.
https://issues.apache.org/jira/browse/HDDS-4198
## How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/1063860191#step:6:10
https://github.com/adoroszlai/hadoop-ozone/runs/1063860210#step:6:10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1387: HDDS-4198. Compile Ozone with multiple Java versions
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1387:
URL: https://github.com/apache/hadoop-ozone/pull/1387#issuecomment-689208686
Thanks @vivekratnavel for the review, and @elek for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #1387: HDDS-4198. Compile Ozone with multiple Java versions
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #1387:
URL: https://github.com/apache/hadoop-ozone/pull/1387#discussion_r483529467
##########
File path: hadoop-ozone/dev-support/checks/build.sh
##########
@@ -17,5 +17,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
export MAVEN_OPTS="-Xmx4096m"
-mvn -B -Dmaven.javadoc.skip=true -DskipTests clean install "$@"
+mvn -V -B -Dmaven.javadoc.skip=true -DskipTests clean install "$@"
Review comment:
`-V` --> very nice, never used this flag #TIL
##########
File path: .github/workflows/post-commit.yml
##########
@@ -34,10 +38,17 @@ jobs:
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-
- - name: Execute tests
- uses: ./.github/buildenv
+ - name: Cache for maven dependencies
+ uses: actions/cache@v2
with:
- args: ./hadoop-ozone/dev-support/checks/build.sh
Review comment:
We can consider doing the same with all the other steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1387: HDDS-4198. Compile Ozone with multiple Java versions
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1387:
URL: https://github.com/apache/hadoop-ozone/pull/1387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org