You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/06 14:47:00 UTC
[jira] [Commented] (TINKERPOP-1706) Remove deprecated
ScriptEngineCache and related dead code
[ https://issues.apache.org/jira/browse/TINKERPOP-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076624#comment-16076624 ]
ASF GitHub Bot commented on TINKERPOP-1706:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/655
TINKERPOP-1706 ScriptEngine related deprecation removal
https://issues.apache.org/jira/browse/TINKERPOP-1706
Pretty simple and straightforward - these were mostly internal classes/fields/methods.
Builds nicely with docker
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1706
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/655.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #655
----
commit 33821696cd6c54b4dad94e3f46aed56f55a16c28
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-07-05T19:46:35Z
TINKERPOP-1706 Removed deprecated ScriptEngineCache and CoreImports
commit d25487e21009bade2f39215aac64aa6740ba014a
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-07-05T20:26:05Z
TINKERPOP-1706 Removed access to CoreGremlinPlugin#INSTANCE previously deprecated
commit d173af8a971b532b9c1e558503406d2bd2743dd8
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-07-05T20:31:34Z
TINKERPOP-1706 Removed old GremlinJythonScriptEngine constructor.
----
> Remove deprecated ScriptEngineCache and related dead code
> ---------------------------------------------------------
>
> Key: TINKERPOP-1706
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1706
> Project: TinkerPop
> Issue Type: Improvement
> Components: groovy
> Affects Versions: 3.2.5
> Reporter: stephen mallette
> Assignee: stephen mallette
> Labels: breaking
>
> {{ScriptEngineCache}} was essentially moved in 3.2.4 - the old one can be removed. Includes removal of {{CoreGremlinPlugin#INSTANCE}} which is now more consistently referred to as {{instance()}} and the old constructor for {{GremlinJythonScriptEngine}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)