You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Dennis Ju (JIRA)" <ji...@apache.org> on 2011/03/11 22:16:14 UTC
[jira] Created: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Passing "rawxml" param w/o "url" param throws exception when processing spec
----------------------------------------------------------------------------
Key: SHINDIG-1516
URL: https://issues.apache.org/jira/browse/SHINDIG-1516
Project: Shindig
Issue Type: Bug
Components: Java
Affects Versions: 2.0.2, 2.0.3, 3.0.0
Reporter: Dennis Ju
Priority: Minor
Fix For: 3.0.0
When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Updated: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by John Hjelmstad <fa...@google.com>.
Hi Dennis:
quick update, could you post this to codereview.appspot.com?
On Fri, Mar 11, 2011 at 1:19 PM, Dennis Ju (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Dennis Ju updated SHINDIG-1516:
> -------------------------------
>
> Attachment: processor.patch
>
> Suggested patch
>
> > Passing "rawxml" param w/o "url" param throws exception when processing
> spec
> >
> ----------------------------------------------------------------------------
> >
> > Key: SHINDIG-1516
> > URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> > Project: Shindig
> > Issue Type: Bug
> > Components: Java
> > Affects Versions: 2.0.2, 2.0.3, 3.0.0
> > Reporter: Dennis Ju
> > Priority: Minor
> > Fix For: 3.0.0
> >
> > Attachments: processor.patch
> >
> >
> > When passing a rawxml parameter to pass the gadget content,
> Processor.java still expects a well-formed url parameter even though it is
> unneeded. A missing url parameter will throw an exception.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
Re: [jira] Updated: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by John Hjelmstad <fa...@google.com>.
Hi Dennis:
quick update, could you post this to codereview.appspot.com?
On Fri, Mar 11, 2011 at 1:19 PM, Dennis Ju (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Dennis Ju updated SHINDIG-1516:
> -------------------------------
>
> Attachment: processor.patch
>
> Suggested patch
>
> > Passing "rawxml" param w/o "url" param throws exception when processing
> spec
> >
> ----------------------------------------------------------------------------
> >
> > Key: SHINDIG-1516
> > URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> > Project: Shindig
> > Issue Type: Bug
> > Components: Java
> > Affects Versions: 2.0.2, 2.0.3, 3.0.0
> > Reporter: Dennis Ju
> > Priority: Minor
> > Fix For: 3.0.0
> >
> > Attachments: processor.patch
> >
> >
> > When passing a rawxml parameter to pass the gadget content,
> Processor.java still expects a well-formed url parameter even though it is
> unneeded. A missing url parameter will throw an exception.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
[jira] Commented: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by "Dennis Ju (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005860#comment-13005860 ]
Dennis Ju commented on SHINDIG-1516:
------------------------------------
Sorry- I haven't gone through this procedure before, so I'm kinda fumbling
around.
Posted here: http://codereview.appspot.com/4284045/
Thanks!
--
*
East Coast Symposium 2011
*
*May 10-11, 2011*
*Register today: www.liferay.com/ECS2011*
*New! Attend Portal Administrator Training
Express<http://www.regonline.com/Register/Checkin.aspx?EventID=918957>
or Building Themes in
Liferay<http://www.regonline.com/Register/Checkin.aspx?EventID=918959>
on May 9 at the same location as ECS!*
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 3.0.0
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: processor.patch
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (SHINDIG-1516) Passing "rawxml" param
w/o "url" param throws exception when processing spec
Posted by "Dennis Ju (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005860#comment-13005860 ]
Dennis Ju edited comment on SHINDIG-1516 at 3/11/11 10:08 PM:
--------------------------------------------------------------
Codereview here: http://codereview.appspot.com/4284045/
Thanks!
was (Author: dennisju):
Sorry- I haven't gone through this procedure before, so I'm kinda fumbling
around.
Posted here: http://codereview.appspot.com/4284045/
Thanks!
--
*
East Coast Symposium 2011
*
*May 10-11, 2011*
*Register today: www.liferay.com/ECS2011*
*New! Attend Portal Administrator Training
Express<http://www.regonline.com/Register/Checkin.aspx?EventID=918957>
or Building Themes in
Liferay<http://www.regonline.com/Register/Checkin.aspx?EventID=918959>
on May 9 at the same location as ECS!*
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 3.0.0
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: processor.patch
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005848#comment-13005848 ]
John Hjelmstad commented on SHINDIG-1516:
-----------------------------------------
Hi Dennis:
quick update, could you post this to codereview.appspot.com?
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 3.0.0
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: processor.patch
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005847#comment-13005847 ]
John Hjelmstad commented on SHINDIG-1516:
-----------------------------------------
Hi Dennis:
quick update, could you post this to codereview.appspot.com?
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 3.0.0
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: processor.patch
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1516.
-----------------------------------
Resolution: Fixed
Thanks! committed.
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 3.0.0
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 3.0.0
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by "Dennis Ju (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Ju updated SHINDIG-1516:
-------------------------------
Attachment: (was: processor.patch)
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 3.0.0
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 3.0.0
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by "Dennis Ju (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Ju updated SHINDIG-1516:
-------------------------------
Attachment: processor.patch
Suggested patch
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 3.0.0
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: processor.patch
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by "Mat Mannion (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005911#comment-13005911 ]
Mat Mannion commented on SHINDIG-1516:
--------------------------------------
Hi Dennis,
Can you re-base your patch to be relative to the root, please, rather than the directory that Processor.java is in? At the moment this is stopping the code review working. It looks okay to me, though there are a couple of indenting issues I think where it doesn't match the shindig style (tabs instead of 4 spaces)
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 3.0.0
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: processor.patch
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1516.
---------------------------------
part of 2.5.0-beta1 release.
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 2.5.0-beta1
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 2.5.0-beta1
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHINDIG-1516) Passing "rawxml" param w/o "url"
param throws exception when processing spec
Posted by "Dennis Ju (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005928#comment-13005928 ]
Dennis Ju commented on SHINDIG-1516:
------------------------------------
Okay, I re-based the patch relative to root and fixed the indenting issues. It's patch set 2 in codereview.
Thanks!
> Passing "rawxml" param w/o "url" param throws exception when processing spec
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1516
> URL: https://issues.apache.org/jira/browse/SHINDIG-1516
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2, 2.0.3, 3.0.0
> Reporter: Dennis Ju
> Priority: Minor
> Fix For: 3.0.0
>
>
> When passing a rawxml parameter to pass the gadget content, Processor.java still expects a well-formed url parameter even though it is unneeded. A missing url parameter will throw an exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira