You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/05/02 19:36:32 UTC
[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3860: [ISSUE #3829]Do some code optimization.[CloudEventUtils]
harshithasudhakar opened a new pull request, #3860:
URL: https://github.com/apache/eventmesh/pull/3860
Fixes #3829
### Modifications
Replaced `replaceAll()` with `replace()` at line 88
Removed `e.printStackTrace()` at line 128
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3860: [ISSUE #3829]Do some code optimization.[CloudEventUtils]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3860:
URL: https://github.com/apache/eventmesh/pull/3860#issuecomment-1533984832
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3860](https://app.codecov.io/gh/apache/eventmesh/pull/3860?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a6dcb5) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/91aab4d4ec18b7644c45e745fc85aafd053d8fd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91aab4d) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 0a6dcb5 differs from pull request most recent head a94404f. Consider uploading reports for the commit a94404f to get more accurate results
```diff
@@ Coverage Diff @@
## master #3860 +/- ##
=========================================
Coverage 13.77% 13.77%
Complexity 1290 1290
=========================================
Files 571 571
Lines 29129 29128 -1
Branches 2837 2837
=========================================
Hits 4012 4012
+ Misses 24745 24744 -1
Partials 372 372
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntmesh/storage/rocketmq/utils/CloudEventUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/3860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvc3RvcmFnZS9yb2NrZXRtcS91dGlscy9DbG91ZEV2ZW50VXRpbHMuamF2YQ==) | `50.81% <0.00%> (+0.81%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mroccyen merged pull request #3860: [ISSUE #3829]Do some code optimization.[CloudEventUtils]
Posted by "mroccyen (via GitHub)" <gi...@apache.org>.
mroccyen merged PR #3860:
URL: https://github.com/apache/eventmesh/pull/3860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org