You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/14 23:39:52 UTC
[GitHub] [lucene-solr] athrog opened a new pull request #1261: SOLR-14260:
Make SchemaRegistryProvider pluggable in HttpClientUtil
athrog opened a new pull request #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
URL: https://github.com/apache/lucene-solr/pull/1261
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
HttpClientUtil.java defines and uses an abstract SchemaRegistryProvider for mapping a protocol to an Apache ConnectionSocketFactory. There is only one implementation of this abstract class (outside of test cases). Currently, it is not override-able at runtime.
# Solution
Adds the ability to override the schema registry provider at runtime, using the class name value provided by "solr.schema.registry.provider", similar to how this class allows for choosing the HttpClientBuilderFactory at runtime.
# Tests
We have been using this patch in our internal fork of SOLR. We have verified that SOLR communication is encrypted, and since this patch helps us enable that encryption by setting a custom SSLContext for HTTP clients, we know this patch is working as expected.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on issue #1261: SOLR-14260: Make
SchemaRegistryProvider pluggable in HttpClientUtil
Posted by GitBox <gi...@apache.org>.
dsmiley commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-604602628
We agree connectionSocketFactoryRegistryProvider is a bit much. I had dropped "Provider" as it seems kinda meta and somewhat redundant with the word also having a "Factory" (Provider ~ Factory), but I can see it could be there. I like your proposal of keeping either one of connection or socket. I propose keep the word socket and drop connection. Or abbreviate "connection" to "conn" which is sufficiently shorter to make me feel better about the fully complete word. Ah naming...
I can see generics may be an issue so yeah keep the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley closed pull request #1261: SOLR-14260: Make
SchemaRegistryProvider pluggable in HttpClientUtil
Posted by GitBox <gi...@apache.org>.
dsmiley closed pull request #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
URL: https://github.com/apache/lucene-solr/pull/1261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] athrog commented on issue #1261: SOLR-14260: Make
SchemaRegistryProvider pluggable in HttpClientUtil
Posted by GitBox <gi...@apache.org>.
athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-586520791
FYI @dsmiley
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] athrog commented on issue #1261: SOLR-14260: Make
SchemaRegistryProvider pluggable in HttpClientUtil
Posted by GitBox <gi...@apache.org>.
athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-604588248
Hi David, thank you for the feedback and my apologies in the delayed response. I agree, 'schema' is an overloaded word in Solr that we could avoid. Your suggestion of `connectionSocketFactoryRegistry` is better, but there's still a Provider on top of that, and having a `connectionSocketFactoryRegistryProvider` sounds like too much Java word-salad to me. Maybe just drop the "connection" (since it's implied by a socket)? Or `connectionSocketFactoriesProvider`?
As to using a Supplier, we could use `Supplier<Registry<ConnectionSocketFactory>>`, but that would be a dodgy cast (at HttpClientUtil.java:161) due to the generics so I think I'll keep it a concrete class for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] athrog commented on issue #1261: SOLR-14260: Make
SchemaRegistryProvider pluggable in HttpClientUtil
Posted by GitBox <gi...@apache.org>.
athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-604724994
Fixed the obsolete comments, just did a grep for old instances and found a few more that needed changing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org