You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/21 06:53:31 UTC
[GitHub] [flink] shizhengchao opened a new pull request #13717: [Flink 19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
shizhengchao opened a new pull request #13717:
URL: https://github.com/apache/flink/pull/13717
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
for example, if statement.executeBatch() failur for some reason, but the "statement" was not closed in the retry, there is a risk of data duplication:
```
for (int i = 1; i <= executionOptions.getMaxRetries(); i++) {
try {
attemptFlush();
batchCount = 0;
break;
} catch (SQLException e) {
LOG.error("JDBC executeBatch error, retry times = {}", i, e);
if (i >= executionOptions.getMaxRetries()) {
throw new IOException(e);
}
try {
if (!connection.isValid(CONNECTION_CHECK_TIMEOUT_SECONDS)) {
connection = connectionProvider.reestablishConnection();
jdbcStatementExecutor.closeStatements();
jdbcStatementExecutor.prepareStatements(connection);
}
} catch (Exception excpetion) {
LOG.error("JDBC connection is not valid, and reestablish connection failed.", excpetion);
throw new IOException("Reestablish JDBC connection failed", excpetion);
}
try {
Thread.sleep(1000 * i);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
throw new IOException("unable to flush; interrupted while doing another attempt", e);
}
}
}
```
Should be always re-prepareStatement to solve the risk of data duplication
```
...
try {
if (!connection.isValid(CONNECTION_CHECK_TIMEOUT_SECONDS)) {
connection = connectionProvider.reestablishConnection();
}
jdbcStatementExecutor.closeStatements();
jdbcStatementExecutor.prepareStatements(connection);
} catch (Exception excpetion) {
LOG.error("JDBC connection is not valid, and reestablish connection failed.", excpetion);
throw new IOException("Reestablish JDBC connection failed", excpetion);
}
```
## Brief change log
- *When the retry occurs in flush method, we should be always re-prepareStatement*
## Verifying this change
This change is already covered by existing tests, such as *JdbcTableOutputFormatTest#testJdbcOutputFormat*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #13717:
URL: https://github.com/apache/flink/pull/13717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-713367394
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7986",
"triggerID" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"triggerType" : "PUSH"
}, {
"hash" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"triggerType" : "PUSH"
}, {
"hash" : "0b43b529385f617abdf97df7a8c6922a9c68fba9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7991",
"triggerID" : "0b43b529385f617abdf97df7a8c6922a9c68fba9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c847b182e847958a23d07da374a4d593fb76b5cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7986)
* 52a481ff6c475c882922a7f4095723af7950cf5c UNKNOWN
* 0b43b529385f617abdf97df7a8c6922a9c68fba9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7991)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shizhengchao commented on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
shizhengchao commented on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-718395751
Hi [~jark], after testing, this is not a bug, could you close the issue?:D
Generally, after executing executeBatch in jdbc, regardless of success or failure, the list of preparedStatements will be cleared
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-713367394
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7986",
"triggerID" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"triggerType" : "PUSH"
}, {
"hash" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"triggerType" : "PUSH"
}, {
"hash" : "0b43b529385f617abdf97df7a8c6922a9c68fba9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7991",
"triggerID" : "0b43b529385f617abdf97df7a8c6922a9c68fba9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c847b182e847958a23d07da374a4d593fb76b5cd Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7986)
* 52a481ff6c475c882922a7f4095723af7950cf5c UNKNOWN
* 0b43b529385f617abdf97df7a8c6922a9c68fba9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7991)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-716965007
Could you add an unit test in `JdbcDynamicOutputFormatTest` to verify this bug fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-713367394
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7986",
"triggerID" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"triggerType" : "PUSH"
}, {
"hash" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"triggerType" : "PUSH"
}, {
"hash" : "0b43b529385f617abdf97df7a8c6922a9c68fba9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0b43b529385f617abdf97df7a8c6922a9c68fba9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c847b182e847958a23d07da374a4d593fb76b5cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7986)
* 52a481ff6c475c882922a7f4095723af7950cf5c UNKNOWN
* 0b43b529385f617abdf97df7a8c6922a9c68fba9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-713353033
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c847b182e847958a23d07da374a4d593fb76b5cd (Wed Oct 21 06:56:21 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-713367394
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c847b182e847958a23d07da374a4d593fb76b5cd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shizhengchao commented on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
shizhengchao commented on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-716976670
> Could you add an unit test in `JdbcDynamicOutputFormatTest` to verify this bug fix?
Thanks for review, i will add unit tests soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-713367394
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7986",
"triggerID" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"triggerType" : "PUSH"
}, {
"hash" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c847b182e847958a23d07da374a4d593fb76b5cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7986)
* 52a481ff6c475c882922a7f4095723af7950cf5c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-713367394
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7986",
"triggerID" : "c847b182e847958a23d07da374a4d593fb76b5cd",
"triggerType" : "PUSH"
}, {
"hash" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "52a481ff6c475c882922a7f4095723af7950cf5c",
"triggerType" : "PUSH"
}, {
"hash" : "0b43b529385f617abdf97df7a8c6922a9c68fba9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7991",
"triggerID" : "0b43b529385f617abdf97df7a8c6922a9c68fba9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52a481ff6c475c882922a7f4095723af7950cf5c UNKNOWN
* 0b43b529385f617abdf97df7a8c6922a9c68fba9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7991)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shizhengchao commented on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
shizhengchao commented on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-715213638
Hi @wuchong , could you help me review this ? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13717: [FLINK-19723][Connector/JDBC] Solve the problem of repeated data submission in the failure retry
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13717:
URL: https://github.com/apache/flink/pull/13717#issuecomment-718402409
Thanks @shizhengchao .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org