You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Jim Cummings (JIRA)" <de...@beehive.apache.org> on 2006/03/07 17:55:40 UTC
[jira] Created: (BEEHIVE-1076) interceptors for annotations don't
get wired into generated control beans if the annotation is at the class
level
interceptors for annotations don't get wired into generated control beans if the annotation is at the class level
-----------------------------------------------------------------------------------------------------------------
Key: BEEHIVE-1076
URL: http://issues.apache.org/jira/browse/BEEHIVE-1076
Project: Beehive
Type: Improvement
Components: Controls
Versions: 1.0.1
Reporter: Jim Cummings
If you have an annotation which is meta-annotated with @InterceptorAnnotation specifying an interceptor service, and you place that annotation on a control at the class-level (on the interface), then the generated control bean doesn't get any interceptor logic wired in for pre/post invoke or pre/post event. Placing the annotation at the method level works as expected.
It would be really nice if you could hook in interceptors for ALL methods by putting the annotation at the class level and having the code gen automatically wire this in for all methods.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-1076) interceptors for annotations don't
get wired into generated control beans if the annotation is at the class
level
Posted by "Chad Schoettger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEEHIVE-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chad Schoettger resolved BEEHIVE-1076.
--------------------------------------
Resolution: Fixed
Fix Version/s: V.Next
Assignee: Jacob Danner (was: Chad Schoettger)
Fixed, svn rev 525186.
Here is the proposed solution from the Beehive developer mailing list:
1) Use the existing Beehive annotation @InterceptorAnnotation to meta-annotate
class-level interceptor annotations. The only difference between a
class-level and method-level interceptor annotation would be the type it
annotates. This would allow a developer to create a single interceptor
annotation which could be used at the class or method level.
2) A class-level interceptor gets applied to each method in the class
(including inherited methods).
3) If a method within an class is annotated with the same interceptor
annotation as the class that interceptor service will be fired only once.
It is up to the interceptor service implementation to determine which interceptor
annotation should apply
4) Interceptor prioritization does not change, method-level and class-level
interceptor priorities could still be defined in the same manner by
controls-interceptors.config file.
> interceptors for annotations don't get wired into generated control beans if the annotation is at the class level
> -----------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-1076
> URL: https://issues.apache.org/jira/browse/BEEHIVE-1076
> Project: Beehive
> Issue Type: Improvement
> Components: Controls
> Affects Versions: 1.0.1
> Reporter: Jim Cummings
> Assigned To: Jacob Danner
> Fix For: V.Next
>
>
> If you have an annotation which is meta-annotated with @InterceptorAnnotation specifying an interceptor service, and you place that annotation on a control at the class-level (on the interface), then the generated control bean doesn't get any interceptor logic wired in for pre/post invoke or pre/post event. Placing the annotation at the method level works as expected.
> It would be really nice if you could hook in interceptors for ALL methods by putting the annotation at the class level and having the code gen automatically wire this in for all methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (BEEHIVE-1076) interceptors for annotations don't
get wired into generated control beans if the annotation is at the class
level
Posted by "Jacob Danner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEEHIVE-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacob Danner closed BEEHIVE-1076.
---------------------------------
Assignee: (was: Jacob Danner)
Closing per Russ's verification and recommendation. Thanks Russ!
> interceptors for annotations don't get wired into generated control beans if the annotation is at the class level
> -----------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-1076
> URL: https://issues.apache.org/jira/browse/BEEHIVE-1076
> Project: Beehive
> Issue Type: Improvement
> Components: Controls
> Affects Versions: 1.0.1
> Reporter: Jim Cummings
> Fix For: V.Next
>
>
> If you have an annotation which is meta-annotated with @InterceptorAnnotation specifying an interceptor service, and you place that annotation on a control at the class-level (on the interface), then the generated control bean doesn't get any interceptor logic wired in for pre/post invoke or pre/post event. Placing the annotation at the method level works as expected.
> It would be really nice if you could hook in interceptors for ALL methods by putting the annotation at the class level and having the code gen automatically wire this in for all methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BEEHIVE-1076) interceptors for annotations don't
get wired into generated control beans if the annotation is at the class
level
Posted by "Chad Schoettger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEEHIVE-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chad Schoettger reassigned BEEHIVE-1076:
----------------------------------------
Assignee: Chad Schoettger
> interceptors for annotations don't get wired into generated control beans if the annotation is at the class level
> -----------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-1076
> URL: https://issues.apache.org/jira/browse/BEEHIVE-1076
> Project: Beehive
> Issue Type: Improvement
> Components: Controls
> Affects Versions: 1.0.1
> Reporter: Jim Cummings
> Assigned To: Chad Schoettger
>
> If you have an annotation which is meta-annotated with @InterceptorAnnotation specifying an interceptor service, and you place that annotation on a control at the class-level (on the interface), then the generated control bean doesn't get any interceptor logic wired in for pre/post invoke or pre/post event. Placing the annotation at the method level works as expected.
> It would be really nice if you could hook in interceptors for ALL methods by putting the annotation at the class level and having the code gen automatically wire this in for all methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BEEHIVE-1076) interceptors for annotations don't
get wired into generated control beans if the annotation is at the class
level
Posted by "Russ Baker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEEHIVE-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498851 ]
Russ Baker commented on BEEHIVE-1076:
-------------------------------------
I verified that the @InterceptorAnnotation works both on the class level as well as the method level. I recommend that this bug be closed.
> interceptors for annotations don't get wired into generated control beans if the annotation is at the class level
> -----------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-1076
> URL: https://issues.apache.org/jira/browse/BEEHIVE-1076
> Project: Beehive
> Issue Type: Improvement
> Components: Controls
> Affects Versions: 1.0.1
> Reporter: Jim Cummings
> Assigned To: Jacob Danner
> Fix For: V.Next
>
>
> If you have an annotation which is meta-annotated with @InterceptorAnnotation specifying an interceptor service, and you place that annotation on a control at the class-level (on the interface), then the generated control bean doesn't get any interceptor logic wired in for pre/post invoke or pre/post event. Placing the annotation at the method level works as expected.
> It would be really nice if you could hook in interceptors for ALL methods by putting the annotation at the class level and having the code gen automatically wire this in for all methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.