PropertyHelper refactoring

[Conor MacNeill <co...@cortexebusiness.com.au>]

I'd like to refactor PropertyHelper a bit and thought I'd get some opinions.

Currently PropertyHelper serves three different roles

1. The basic interface definition of a PropertyHelper
2. The implementation of the standard PropertyHelper
3. The factory for creating PropertyHelpers.

I'd like to separate the first two at least. As it stands, it is not clear 
which methods are part of the interface used by Project and which are just 
part of the standard implementation. Over time that will lead to confusion 
between the two roles.

So, I'd like to make PropertyHelper abstract and create a 
StandardPropertyHelper to implement the default behaviour. The factory method 
can remain in the abstract class. The PropertyHelper chaining could also stay 
and perhaps become final too.

I haven't looked in detail but ComponentHelper is probably going to be the 
same. Probably too late for ProjectHelper :-)

Thoughts?

Conor


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Re: PropertyHelper refactoring

[Stefan Bodewig <bo...@apache.org>]

On Sun, 6 Jul 2003, Conor MacNeill <co...@cortexebusiness.com.au>
wrote:

> So, I'd like to make PropertyHelper abstract and create a
> StandardPropertyHelper to implement the default behaviour. The
> factory method can remain in the abstract class. The PropertyHelper
> chaining could also stay

+1

> and perhaps become final too.

I think so, but need to reread that code once again.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org