You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2022/05/09 06:51:10 UTC

[kudu-CR] [KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact

Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18503

to look at the new patch set (#3).

Change subject: [KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact
......................................................................

[KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact

If we get a REDO delta with full of delete op, wich means there is no update op
in the file. The current compact algorithm will not schedule the file do compact.
If such files exist, after accumulating for a period of time, it will greatly
affect our scan speed. However, processing such files every time compact reduces
compact's performance.

So I added a flag FLAGS_ignore_delete_op_for_compact to solve this situation.
When we found a similar situation, we can schedule the compact algorithm to deal
with REDO deltas by set FLAGS_ignore_delete_op_for_compact to false. When we solve
this problem, we need to restore the flag to true to ensure that the compact
performance will not be affected.

Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed
---
M src/kudu/common/row_changelist.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/diskrowset-test-base.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
8 files changed, 154 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/18503/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed
Gerrit-Change-Number: 18503
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>