You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Seckin Onur SELAMET (JIRA)" <ji...@apache.org> on 2018/05/22 13:14:00 UTC
[jira] [Comment Edited] (MNG-6415) Project Artifacts Cache does not
retain the order of classpath entries.
[ https://issues.apache.org/jira/browse/MNG-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483775#comment-16483775 ]
Seckin Onur SELAMET edited comment on MNG-6415 at 5/22/18 1:13 PM:
-------------------------------------------------------------------
Rev no : be223808939d75152d7157db33d45f230114555e
Class : DefaultProjectArtifactsCache
Line : 208
{color:#ff0000}_new CacheRecord( Collections.unmodifiableSet( new HashSet<>( projectArtifacts ) ) );_{color}
Must be implemented as:
new CacheRecord( Collections.unmodifiableSet( new LinkedHashSet<>( projectArtifacts ) ) );
Patch is also available in attachments.
was (Author: soselamet):
Rev no : be223808939d75152d7157db33d45f230114555e
Line : 208
{color:#FF0000}_new CacheRecord( Collections.unmodifiableSet( new HashSet<>( projectArtifacts ) ) );_{color}
Must be implemented as:
new CacheRecord( Collections.unmodifiableSet( new LinkedHashSet<>( projectArtifacts ) ) );
> Project Artifacts Cache does not retain the order of classpath entries.
> -----------------------------------------------------------------------
>
> Key: MNG-6415
> URL: https://issues.apache.org/jira/browse/MNG-6415
> Project: Maven
> Issue Type: Bug
> Components: core
> Affects Versions: 3.5.2
> Environment: Windows 7, JDK8u144
> Reporter: Seckin Onur SELAMET
> Priority: Major
> Labels: CLASSPATH
> Attachments: [MNG-6415]_Fixes_Project_Artifact_Cache_classpath_order_retaining_issue_.patch
>
>
> Project artifact cache introduced does not retain the order of classpath entries.
> Wrong Object type used in implementation. HashSet can not guarantee the order of elements contained.
> In runtime ProjectArtifacts passed as LinkedHashSet already which is safe.
>
> Possible fix is provided in comments section.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)