You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/08/08 17:16:22 UTC

[PR] docs: define how to pick a PR title's type and scope [texera]

Yicong-Huang opened a new pull request, #7427:
URL: https://github.com/apache/texera/pull/7427

### What changes were proposed in this PR?

`CONTRIBUTING.md` requires Conventional Commits for PR titles but never says how to pick the type or scope, so recurring cases get decided ad hoc. This writes the convention down:

- **Type follows the behavior**, not the diff size:
- worked before, broken now → `fix`
- adding, removing, or reworking a functionality → `feat`
- guaranteed to leave observable behavior unchanged → `refactor`, which must keep the existing tests passing untouched
- **Tests**: a test-only PR is `test(<module>)`; repairing a broken or flaky test is `fix(test, <module>)`.
- **Dependencies**: `fix(deps, <module>)` when the bump patches a CVE, `chore(deps, <module>)` otherwise, `ci:` for CI-only bumps.
- **Backports**: a release-branch PR appends the version as the last scope component, e.g. `fix(deps, frontend, v1.2): ...`.

One behavior change worth flagging. `backport-auto-label.yml` auto-labels only `fix(...)` PRs. The CVE/non-CVE split therefore narrows auto-backporting to security bumps, where the old runtime-vs-toolchain split sent every runtime bump there.

### Any related issues, documentation, discussions?

Closes #7393

### How was this PR tested?

- Documentation only — no code path changes.
- Verified the new title forms pass the CI type gate and the review-time title check, both on `main` and with a version scope on `release/v1.2`.
- Confirmed `direct-backport-push.yml`'s rewriter already emits the documented backport form, so no workflow change is needed.

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.

Yicong-Huang commented on code in PR #7427:
URL: https://github.com/apache/texera/pull/7427#discussion_r3744430221


##########
docs/contribution-guidelines/_index.md:
##########
@@ -72,6 +72,31 @@ We use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/):
   - `chore(deps): bump dependency versions`
 - The PR title becomes the final squashed commit message upon merge.
 
+Pick the type by what happens to the behavior, not by how large the change is:

Review Comment:
   Currently we keep an additional copy of doc. the copy in `_index.md` is the one shown on texera.apache.org and the copy in CONTRIBUTING.md is the one shows on github. let's handle this dup separately. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.

Yicong-Huang merged PR #7427:
URL: https://github.com/apache/texera/pull/7427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.

aglinxinyuan commented on code in PR #7427:
URL: https://github.com/apache/texera/pull/7427#discussion_r3742732252


##########
docs/contribution-guidelines/_index.md:
##########
@@ -72,6 +72,31 @@ We use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/):
   - `chore(deps): bump dependency versions`
 - The PR title becomes the final squashed commit message upon merge.
 
+Pick the type by what happens to the behavior, not by how large the change is:

Review Comment:
   Just point to CONTRIBUTING.md?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #7427:
URL: https://github.com/apache/texera/pull/7427#issuecomment-5227231583

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7427?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 84.70%. Comparing base ([`5e41efa`](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`968133c`](https://app.codecov.io/gh/apache/texera/commit/968133cb718957d36c56a81127667001c67aa452?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 16 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #7427   +/-   ##
   =========================================
     Coverage     84.70%   84.70%           
     Complexity     4153     4153           
   =========================================
     Files          1169     1169           
     Lines         46740    46740           
     Branches       5202     5202           
   =========================================
     Hits          39592    39592           
     Misses         5433     5433           
     Partials       1715     1715           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [5e41efa](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.50% <ø> (ø)` | | |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.87% <ø> (ø)` | | Carriedforward from [5e41efa](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.72% <ø> (ø)` | | Carriedforward from [5e41efa](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.97% <ø> (ø)` | | Carriedforward from [5e41efa](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.05% <ø> (ø)` | | Carriedforward from [5e41efa](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.45% <ø> (ø)` | | Carriedforward from [5e41efa](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.89% <ø> (ø)` | | Carriedforward from [5e41efa](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.55% <ø> (ø)` | | Carriedforward from [5e41efa](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (ø)` | | Carriedforward from [5e41efa](https://app.codecov.io/gh/apache/texera/commit/5e41efae2650c3e70d7490b15bb1fdf9b1983568?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7427?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #7427:
URL: https://github.com/apache/texera/pull/7427#issuecomment-5227266452

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 4 better · 🔴 5 worse · ⚪ 6 noise (<±5%) · 0 without baseline
   
   > Compared against main `3534662` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/31269165807)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🔴 | bs=10 sw=10 sl=64 | 416 | 0.254 | 24,640/28,809/28,809 us | 🔴 +13.3% / 🔴 +89.5% |
   | 🟢 | bs=100 sw=10 sl=64 | 945 | 0.577 | 105,139/116,850/116,850 us | 🟢 -13.1% / 🔴 +5.1% |
   | 🔴 | bs=1000 sw=10 sl=64 | 1,089 | 0.664 | 913,434/1,045,273/1,045,273 us | 🔴 +7.8% / 🟢 -10.8% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `3534662` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 416 tuples/sec | 448 tuples/sec | 752.25 tuples/sec | -7.1% | -44.7% |
   | bs=10 sw=10 sl=64 | MB/s | 0.254 MB/s | 0.274 MB/s | 0.459 MB/s | -7.3% | -44.7% |
   | bs=10 sw=10 sl=64 | p50 | 24,640 us | 21,749 us | 13,006 us | +13.3% | +89.5% |
   | bs=10 sw=10 sl=64 | p95 | 28,809 us | 31,689 us | 16,117 us | -9.1% | +78.7% |
   | bs=10 sw=10 sl=64 | p99 | 28,809 us | 31,689 us | 19,286 us | -9.1% | +49.4% |
   | bs=100 sw=10 sl=64 | throughput | 945 tuples/sec | 971 tuples/sec | 953.66 tuples/sec | -2.7% | -0.9% |
   | bs=100 sw=10 sl=64 | MB/s | 0.577 MB/s | 0.593 MB/s | 0.582 MB/s | -2.7% | -0.9% |
   | bs=100 sw=10 sl=64 | p50 | 105,139 us | 100,784 us | 105,130 us | +4.3% | +0.0% |
   | bs=100 sw=10 sl=64 | p95 | 116,850 us | 134,525 us | 111,226 us | -13.1% | +5.1% |
   | bs=100 sw=10 sl=64 | p99 | 116,850 us | 134,525 us | 121,065 us | -13.1% | -3.5% |
   | bs=1000 sw=10 sl=64 | throughput | 1,089 tuples/sec | 1,106 tuples/sec | 984.25 tuples/sec | -1.5% | +10.6% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.664 MB/s | 0.675 MB/s | 0.601 MB/s | -1.6% | +10.5% |
   | bs=1000 sw=10 sl=64 | p50 | 913,434 us | 903,555 us | 1,024,295 us | +1.1% | -10.8% |
   | bs=1000 sw=10 sl=64 | p95 | 1,045,273 us | 969,983 us | 1,062,710 us | +7.8% | -1.6% |
   | bs=1000 sw=10 sl=64 | p99 | 1,045,273 us | 969,983 us | 1,095,400 us | +7.8% | -4.6% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,480.32,200,128000,416,0.254,24640.47,28809.31,28809.31
   1,100,10,64,20,2115.93,2000,1280000,945,0.577,105138.54,116849.83,116849.83
   2,1000,10,64,20,18371.12,20000,12800000,1089,0.664,913434.44,1045273.16,1045273.16
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.

Copilot commented on code in PR #7427:
URL: https://github.com/apache/texera/pull/7427#discussion_r3742732201


##########
CONTRIBUTING.md:
##########
@@ -54,6 +54,37 @@ Thank you for your interest in contributing to Texera! Please follow the steps b
   - `fix(ui): prevent racing of requests`
   - `chore(deps): bump numpy to version 2.0.0`
 
+##### Choosing between `feat`, `fix`, and `refactor`
+
+The type depends on what happens to the behavior, not on how large the change is.
+
+| Your change | Type |
+| ----------- | ---- |
+| A functionality worked before and no longer does | `fix` |
+| A functionality or a form of support never existed and you are adding it | `feat` |
+| A functionality exists and you are removing support for it | `feat` |
+| A functionality works but is hard to use, and you are reworking it | `feat` |
+| The change leaves the user-facing behavior unchanged | `refactor` |
+
+`refactor` is a strong claim: it says the **user-facing** behavior is identical. The test suite is how you check that, but not every test carries the same weight. A test that pins a user-facing API is the contract — if you had to change one of its assertions to make the suite green, the behavior moved, and the PR is a `feat` or a `fix`. A test that pins internals, such as a private helper's signature, the call order between two collaborators, or the shape of an intermediate value, is mirroring the implementation; rewriting it alongside the code it mirrors is expected and still a `refactor`.
+
+##### Tests and dependency bumps
+
+Two cases use a two-part scope, written as `<type>(<area>, <module>): <description>`:
+
+| Your change | Title |
+| ----------- | ----- |
+| A test-only PR — adding or updating tests | `test(<module>): ...`, e.g. `test(amber): add marker replay specs` |
+| Repairing a broken or flaky test | `fix(test, <module>): ...`, e.g. `fix(test, frontend): stabilize the dashboard spec` |
+| A dependency bump that patches a CVE | `fix(deps, <module>): ...`, e.g. `fix(deps, pyamber): bump protobuf for CVE-2025-4565` |
+| Any other dependency bump | `chore(deps, <module>): ...`, e.g. `chore(deps, frontend): bump numpy to 2.0.0` |

Review Comment:
   The example for a non-CVE dependency bump uses `frontend` as the module scope for a NumPy bump, but NumPy is a Python dependency (it appears in `amber/requirements.txt`). This example should use a Python-related module scope (e.g., `pyamber`) to avoid misleading contributors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.

Yicong-Huang commented on code in PR #7427:
URL: https://github.com/apache/texera/pull/7427#discussion_r3744466633


##########
CONTRIBUTING.md:
##########
@@ -54,6 +54,37 @@ Thank you for your interest in contributing to Texera! Please follow the steps b
   - `fix(ui): prevent racing of requests`
   - `chore(deps): bump numpy to version 2.0.0`
 
+##### Choosing between `feat`, `fix`, and `refactor`
+
+The type depends on what happens to the behavior, not on how large the change is.
+
+| Your change | Type |
+| ----------- | ---- |
+| A functionality worked before and no longer does | `fix` |
+| A functionality or a form of support never existed and you are adding it | `feat` |
+| A functionality exists and you are removing support for it | `feat` |
+| A functionality works but is hard to use, and you are reworking it | `feat` |

Review Comment:
   changed! that's more clear!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.

Yicong-Huang commented on code in PR #7427:
URL: https://github.com/apache/texera/pull/7427#discussion_r3744414065


##########
CONTRIBUTING.md:
##########
@@ -54,6 +54,37 @@ Thank you for your interest in contributing to Texera! Please follow the steps b
   - `fix(ui): prevent racing of requests`
   - `chore(deps): bump numpy to version 2.0.0`
 
+##### Choosing between `feat`, `fix`, and `refactor`
+
+The type depends on what happens to the behavior, not on how large the change is.
+
+| Your change | Type |
+| ----------- | ---- |
+| A functionality worked before and no longer does | `fix` |
+| A functionality or a form of support never existed and you are adding it | `feat` |

Review Comment:
   It should be a `feat`. Behavior is defined by the code. If a feature has never existed in the codebase, then it does not exist, even if a PR description or documentation says otherwise. Implementing that behavior is therefore introducing a new feature.
   
   Issues like this happen when reviewers do not verify PR descriptions and documentation against the actual code. I hope AI-assisted reviews will help us catch these inconsistencies and reduce cases where features are documented as existing but do not actually exist. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #7427:
URL: https://github.com/apache/texera/pull/7427#issuecomment-5227228567

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - **Committers with relevant context:** `@parshimers`
     You can request their reviews formally with `/request-review @parshimers`.
   
   - **Contributors with relevant context:** `@aglinxinyuan`
     You can notify them by mentioning `@aglinxinyuan` in a comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: define how to pick a PR title's type and scope [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.

xuang7 commented on code in PR #7427:
URL: https://github.com/apache/texera/pull/7427#discussion_r3742776816


##########
CONTRIBUTING.md:
##########
@@ -54,6 +54,37 @@ Thank you for your interest in contributing to Texera! Please follow the steps b
   - `fix(ui): prevent racing of requests`
   - `chore(deps): bump numpy to version 2.0.0`
 
+##### Choosing between `feat`, `fix`, and `refactor`
+
+The type depends on what happens to the behavior, not on how large the change is.
+
+| Your change | Type |
+| ----------- | ---- |
+| A functionality worked before and no longer does | `fix` |
+| A functionality or a form of support never existed and you are adding it | `feat` |
+| A functionality exists and you are removing support for it | `feat` |
+| A functionality works but is hard to use, and you are reworking it | `feat` |

Review Comment:
   Would it be clearer to define this in terms of user-facing behavior rather than whether the functionality is "hard to use"? For example, "Existing functionality is reworked in a way that intentionally changes user-facing behavior."



##########
CONTRIBUTING.md:
##########
@@ -54,6 +54,37 @@ Thank you for your interest in contributing to Texera! Please follow the steps b
   - `fix(ui): prevent racing of requests`
   - `chore(deps): bump numpy to version 2.0.0`
 
+##### Choosing between `feat`, `fix`, and `refactor`
+
+The type depends on what happens to the behavior, not on how large the change is.
+
+| Your change | Type |
+| ----------- | ---- |
+| A functionality worked before and no longer does | `fix` |
+| A functionality or a form of support never existed and you are adding it | `feat` |

Review Comment:
   Would this case be considered a fix or a feat? For example, if the existing behavior is incorrect and the PR restores the intended behavior, but the functionality may never have worked correctly before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org