[GitHub] nathanejohnson commented on a change in pull request #3133: feature: add libvirt / qemu io bursting

[GitBox <gi...@apache.org>]

nathanejohnson commented on a change in pull request #3133: feature: add libvirt / qemu io bursting
URL: https://github.com/apache/cloudstack/pull/3133#discussion_r248358220
 
 

 ##########
 File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##########
 @@ -2368,54 +2376,69 @@ protected ServiceOfferingVO createServiceOffering(final long userId, final boole
                 limitResourceUse, volatileVm, displayText, typedProvisioningType, localStorageRequired, false, tags, isSystem, vmType,
                 domainId, hostTag, deploymentPlanner);
 
-        if (isCustomizedIops != null) {
-            bytesReadRate = null;
-            bytesWriteRate = null;
-            iopsReadRate = null;
-            iopsWriteRate = null;
-
-            if (isCustomizedIops) {
+        if (Boolean.TRUE.equals(isCustomizedIops)) {
 
 Review comment:
   In this section, the previous version of the code treated isCustomizedIops null value distinctly from isCustomizedIops false value.  I am reasonably sure they should be treated the same, and also it nulled out values for bytesReadRate / bytesWriteRate .  I'd love some other eyes on this, as I'm not entirely sure what the original intent of the code was and I may be stepping on someone's expected behavior here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services