You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2018/10/11 00:42:39 UTC

[incubator-skywalking] branch fix-alarm-silence created (now 793401a)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch fix-alarm-silence
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.


      at 793401a  Alarm silence init wrong.

This branch includes the following new commits:

     new 793401a  Alarm silence init wrong.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[incubator-skywalking] 01/01: Alarm silence init wrong.

Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch fix-alarm-silence
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git

commit 793401a0f7d3c90205445dfedadb03fa85b97d56
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Thu Oct 11 08:42:31 2018 +0800

    Alarm silence init wrong.
---
 .../apache/skywalking/oap/server/core/alarm/provider/RulesReader.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
index 897d892..3a511ad 100644
--- a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
+++ b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
@@ -63,7 +63,7 @@ public class RulesReader {
                         alarmRule.setOp((String)settings.get("op"));
                         alarmRule.setPeriod((Integer)settings.getOrDefault("period", 1));
                         alarmRule.setCount((Integer)settings.getOrDefault("count", 1));
-                        alarmRule.setSilencePeriod((Integer)settings.getOrDefault("silence-period", alarmRule.getPeriod()));
+                        alarmRule.setSilencePeriod((Integer)settings.getOrDefault("silence-period", -1));
                         alarmRule.setMessage((String)settings.getOrDefault("message", "Alarm caused by Rule " + alarmRule.getAlarmRuleName()));
 
                         rules.getRules().add(alarmRule);