You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/08/31 03:54:25 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #33934: Replace sequence concatination by unpacking in Airflow core

uranusjr commented on code in PR #33934:
URL: https://github.com/apache/airflow/pull/33934#discussion_r1311060232


##########
airflow/models/dag.py:
##########
@@ -1699,7 +1699,7 @@ def _get_task_instances(
         if include_subdags:
             # Crafting the right filter for dag_id and task_ids combo
             conditions = []
-            for dag in self.subdags + [self]:
+            for dag in [*self.subdags, self]:

Review Comment:
   I wonder if `itertools.chain` would be better here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org