You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/06 09:20:08 UTC

[GitHub] [beam] mxm commented on a change in pull request #11558: [BEAM-8742] Add stateful and timely processing benchmarks

mxm commented on a change in pull request #11558:
URL: https://github.com/apache/beam/pull/11558#discussion_r420653166



##########
File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy
##########
@@ -142,9 +249,22 @@ PhraseTriggeringPostCommitBuilder.postCommitJob(
   'Load Tests Python ParDo Flink Batch suite',
   this
 ) {
-  loadTest(delegate, CommonTestProperties.TriggeringContext.PR)
+  loadBatchTests(delegate, CommonTestProperties.TriggeringContext.PR)
+}
+
+PhraseTriggeringPostCommitBuilder.postCommitJob(
+    'beam_LoadTests_Python_ParDo_Flink_Streaming',

Review comment:
       There is one for batch and one for streaming. I think that makes sense, a lot of times we want to see the impact on either of those. 
   
   If you are referring to the args, this is the signature of the `postCommitjob`:
   
   ```
     static void postCommitJob(nameBase,
                               triggerPhrase,
                               githubUiHint,
                               scope,
                               jobDefinition = {}) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org