You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/12/25 23:32:36 UTC
(commons-beanutils) 02/07: Don't initialize instance variables to their default values
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch 1.X
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit 7ed14f123a0463ec60c2a73d83af3d126e38e780
Author: Gary D. Gregory <ga...@gmail.com>
AuthorDate: Wed Dec 25 18:16:53 2024 -0500
Don't initialize instance variables to their default values
---
.../java/org/apache/commons/beanutils/WrapDynaClass.java | 2 +-
.../commons/beanutils/converters/AbstractConverter.java | 2 +-
.../apache/commons/beanutils/locale/BaseLocaleConverter.java | 2 +-
.../org/apache/commons/beanutils/BeanUtilsBenchCase.java | 12 ++++++------
.../apache/commons/beanutils/IndexedPropertyTestCase.java | 2 +-
.../org/apache/commons/beanutils/PropertyUtilsBenchCase.java | 12 ++++++------
src/test/java/org/apache/commons/beanutils/TestBean.java | 10 +++++-----
.../org/apache/commons/beanutils/bugs/Jira411TestCase.java | 2 +-
.../beanutils/converters/BigDecimalConverterTestCase.java | 2 +-
.../beanutils/converters/BigIntegerConverterTestCase.java | 2 +-
.../commons/beanutils/converters/ByteConverterTestCase.java | 2 +-
.../beanutils/converters/DoubleConverterTestCase.java | 2 +-
.../commons/beanutils/converters/FileConverterTestCase.java | 2 +-
.../commons/beanutils/converters/FloatConverterTestCase.java | 2 +-
.../beanutils/converters/IntegerConverterTestCase.java | 2 +-
.../commons/beanutils/converters/LongConverterTestCase.java | 2 +-
.../commons/beanutils/converters/ShortConverterTestCase.java | 2 +-
.../commons/beanutils/converters/URLConverterTestCase.java | 2 +-
18 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/src/main/java/org/apache/commons/beanutils/WrapDynaClass.java b/src/main/java/org/apache/commons/beanutils/WrapDynaClass.java
index 77cd021d..81621025 100644
--- a/src/main/java/org/apache/commons/beanutils/WrapDynaClass.java
+++ b/src/main/java/org/apache/commons/beanutils/WrapDynaClass.java
@@ -269,7 +269,7 @@ public class WrapDynaClass implements DynaClass {
/**
* Name of the JavaBean class represented by this WrapDynaClass.
*/
- private String beanClassName = null;
+ private String beanClassName;
/**
* Reference to the JavaBean class represented by this WrapDynaClass.
diff --git a/src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java b/src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java
index f01996fc..726076ed 100644
--- a/src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java
+++ b/src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java
@@ -77,7 +77,7 @@ public abstract class AbstractConverter implements Converter {
/**
* The default value specified to our Constructor, if any.
*/
- private Object defaultValue = null;
+ private Object defaultValue;
/**
diff --git a/src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java b/src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java
index 2d23f401..dd82f717 100644
--- a/src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java
+++ b/src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java
@@ -72,7 +72,7 @@ public abstract class BaseLocaleConverter implements LocaleConverter {
private final Log log = LogFactory.getLog(BaseLocaleConverter.class);
/** The default value specified to our Constructor, if any. */
- private Object defaultValue = null;
+ private Object defaultValue;
/** Should we return the default value on conversion errors? */
protected boolean useDefault = false;
diff --git a/src/test/java/org/apache/commons/beanutils/BeanUtilsBenchCase.java b/src/test/java/org/apache/commons/beanutils/BeanUtilsBenchCase.java
index 4cd14c1b..0a4898af 100644
--- a/src/test/java/org/apache/commons/beanutils/BeanUtilsBenchCase.java
+++ b/src/test/java/org/apache/commons/beanutils/BeanUtilsBenchCase.java
@@ -54,20 +54,20 @@ public class BeanUtilsBenchCase extends TestCase {
private long counter = 100000;
// DynaClass for inDyna and outDyna
- private DynaClass dynaClass = null;
+ private DynaClass dynaClass;
// Input objects that have identical sets of properties and values.
- private BenchBean inBean = null;
- private DynaBean inDyna = null;
+ private BenchBean inBean;
+ private DynaBean inDyna;
private Map<String, Object> inMap = null; // Map of Objects requiring no conversion
private Map<String, String> inStrs = null; // Map of Strings requiring conversion
// Output objects that have identical sets of properties.
- private BenchBean outBean = null;
- private DynaBean outDyna = null;
+ private BenchBean outBean;
+ private DynaBean outDyna;
// BeanUtilsBean instance to be used
- private BeanUtilsBean bu = null;
+ private BeanUtilsBean bu;
diff --git a/src/test/java/org/apache/commons/beanutils/IndexedPropertyTestCase.java b/src/test/java/org/apache/commons/beanutils/IndexedPropertyTestCase.java
index 12fd6628..faea7048 100644
--- a/src/test/java/org/apache/commons/beanutils/IndexedPropertyTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/IndexedPropertyTestCase.java
@@ -43,7 +43,7 @@ public class IndexedPropertyTestCase {
/**
* The test bean for each test.
*/
- private IndexedTestBean bean = null;
+ private IndexedTestBean bean;
private BeanUtilsBean beanUtilsBean;
private PropertyUtilsBean propertyUtilsBean;
private String[] testArray;
diff --git a/src/test/java/org/apache/commons/beanutils/PropertyUtilsBenchCase.java b/src/test/java/org/apache/commons/beanutils/PropertyUtilsBenchCase.java
index 29bdec03..f983f651 100644
--- a/src/test/java/org/apache/commons/beanutils/PropertyUtilsBenchCase.java
+++ b/src/test/java/org/apache/commons/beanutils/PropertyUtilsBenchCase.java
@@ -53,19 +53,19 @@ public class PropertyUtilsBenchCase extends TestCase {
private long counter = 100000;
// DynaClass for inDyna and outDyna
- private DynaClass dynaClass = null;
+ private DynaClass dynaClass;
// Input objects that have identical sets of properties and values.
- private BenchBean inBean = null;
- private DynaBean inDyna = null;
+ private BenchBean inBean;
+ private DynaBean inDyna;
private Map<String, Object> inMap = null;
// Output objects that have identical sets of properties.
- private BenchBean outBean = null;
- private DynaBean outDyna = null;
+ private BenchBean outBean;
+ private DynaBean outDyna;
// PropertyUtilsBean instance to be used
- private PropertyUtilsBean pu = null;
+ private PropertyUtilsBean pu;
diff --git a/src/test/java/org/apache/commons/beanutils/TestBean.java b/src/test/java/org/apache/commons/beanutils/TestBean.java
index 6cdecf09..23e7dc90 100644
--- a/src/test/java/org/apache/commons/beanutils/TestBean.java
+++ b/src/test/java/org/apache/commons/beanutils/TestBean.java
@@ -184,24 +184,24 @@ private java.util.Date dateProperty;
/**
* A nested reference to another test bean (populated as needed).
*/
- private TestBean nested = null;
+ private TestBean nested;
/**
* Another nested reference to another test bean,
*/
- private TestBean anotherNested = null;
+ private TestBean anotherNested;
/**
* Another nested reference to another test bean,
*/
- private DynaBean nestedDynaBean = null;
+ private DynaBean nestedDynaBean;
- private MappedTestBean mappedNested = null;
+ private MappedTestBean mappedNested;
/**
* A String property with an initial value of null.
*/
- private String nullProperty = null;
+ private String nullProperty;
/**
* A read-only String property.
diff --git a/src/test/java/org/apache/commons/beanutils/bugs/Jira411TestCase.java b/src/test/java/org/apache/commons/beanutils/bugs/Jira411TestCase.java
index 96be0f58..d22ffa1f 100644
--- a/src/test/java/org/apache/commons/beanutils/bugs/Jira411TestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/bugs/Jira411TestCase.java
@@ -30,7 +30,7 @@ public class Jira411TestCase extends TestCase {
public class DummyBean {
- private String imgLink = null;
+ private String imgLink;
public String getImgLink() {
return imgLink;
diff --git a/src/test/java/org/apache/commons/beanutils/converters/BigDecimalConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/BigDecimalConverterTestCase.java
index b1de35b3..fd154a35 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/BigDecimalConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/BigDecimalConverterTestCase.java
@@ -51,7 +51,7 @@ public class BigDecimalConverterTestCase extends NumberConverterTestBase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
public BigDecimalConverterTestCase(final String name) {
super(name);
diff --git a/src/test/java/org/apache/commons/beanutils/converters/BigIntegerConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/BigIntegerConverterTestCase.java
index c833ea74..938eff3d 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/BigIntegerConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/BigIntegerConverterTestCase.java
@@ -36,7 +36,7 @@ public class BigIntegerConverterTestCase extends NumberConverterTestBase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
// ------------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/beanutils/converters/ByteConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/ByteConverterTestCase.java
index 36cfac2b..cdaa0984 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/ByteConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/ByteConverterTestCase.java
@@ -35,7 +35,7 @@ public class ByteConverterTestCase extends NumberConverterTestBase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
// ------------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/beanutils/converters/DoubleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/DoubleConverterTestCase.java
index e0acb5cb..b25acfd0 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/DoubleConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/DoubleConverterTestCase.java
@@ -35,7 +35,7 @@ public class DoubleConverterTestCase extends NumberConverterTestBase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
// ------------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/beanutils/converters/FileConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/FileConverterTestCase.java
index 570aae2d..631dfb3b 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/FileConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/FileConverterTestCase.java
@@ -39,7 +39,7 @@ public class FileConverterTestCase extends TestCase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
// ------------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java
index 94a94c89..0b4c905d 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java
@@ -35,7 +35,7 @@ public class FloatConverterTestCase extends NumberConverterTestBase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
// ------------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/beanutils/converters/IntegerConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/IntegerConverterTestCase.java
index df5d3f38..f17b22c4 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/IntegerConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/IntegerConverterTestCase.java
@@ -36,7 +36,7 @@ public class IntegerConverterTestCase extends NumberConverterTestBase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
// ------------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/beanutils/converters/LongConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/LongConverterTestCase.java
index 3367567d..79a594ee 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/LongConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/LongConverterTestCase.java
@@ -35,7 +35,7 @@ public class LongConverterTestCase extends NumberConverterTestBase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
// ------------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/beanutils/converters/ShortConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/ShortConverterTestCase.java
index 348806a2..45d96775 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/ShortConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/ShortConverterTestCase.java
@@ -35,7 +35,7 @@ public class ShortConverterTestCase extends NumberConverterTestBase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
// ------------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/beanutils/converters/URLConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/URLConverterTestCase.java
index 142cc3c9..2506ae4b 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/URLConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/URLConverterTestCase.java
@@ -39,7 +39,7 @@ public class URLConverterTestCase extends TestCase {
// ------------------------------------------------------------------------
- private Converter converter = null;
+ private Converter converter;
// ------------------------------------------------------------------------