You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/02 13:37:51 UTC

[GitHub] [flink] pnowojski opened a new pull request #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread

pnowojski opened a new pull request #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread
URL: https://github.com/apache/flink/pull/10749
 
 
   CancelTaskException can be thrown for example from LocalInputChannel#getNextBuffer even if the current (down stream) task hasn't YET been canceled. This restores the behaviour to before [FLINK-15317].
       
   StreamTask is able to correctly process/handle CancelTaskException.
   
   ## Verifying this change
   
   This adds a new test and is also covered by some end to end tests that were able to detect the issue in the first place.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread
URL: https://github.com/apache/flink/pull/10749#issuecomment-570210245
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 985071ee68275279789855afa4c781e2d012ea02 (Thu Jan 02 13:41:15 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread
URL: https://github.com/apache/flink/pull/10749#issuecomment-570221188
 
 
   <!--
   Meta data
   Hash:985071ee68275279789855afa4c781e2d012ea02 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142877777 TriggerType:PUSH TriggerID:985071ee68275279789855afa4c781e2d012ea02
   Hash:985071ee68275279789855afa4c781e2d012ea02 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4048 TriggerType:PUSH TriggerID:985071ee68275279789855afa4c781e2d012ea02
   -->
   ## CI report:
   
   * 985071ee68275279789855afa4c781e2d012ea02 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142877777) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4048) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread
URL: https://github.com/apache/flink/pull/10749#issuecomment-570221188
 
 
   <!--
   Meta data
   Hash:985071ee68275279789855afa4c781e2d012ea02 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:985071ee68275279789855afa4c781e2d012ea02
   -->
   ## CI report:
   
   * 985071ee68275279789855afa4c781e2d012ea02 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread
URL: https://github.com/apache/flink/pull/10749#issuecomment-570220092
 
 
   Looks good to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski merged pull request #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread

Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread
URL: https://github.com/apache/flink/pull/10749
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread
URL: https://github.com/apache/flink/pull/10749#issuecomment-570221188
 
 
   <!--
   Meta data
   Hash:985071ee68275279789855afa4c781e2d012ea02 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142877777 TriggerType:PUSH TriggerID:985071ee68275279789855afa4c781e2d012ea02
   Hash:985071ee68275279789855afa4c781e2d012ea02 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4048 TriggerType:PUSH TriggerID:985071ee68275279789855afa4c781e2d012ea02
   -->
   ## CI report:
   
   * 985071ee68275279789855afa4c781e2d012ea02 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142877777) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4048) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10749: [FLINK-15403][task] Allow the CancelTaskException to be thrown from mailbox thread
URL: https://github.com/apache/flink/pull/10749#issuecomment-570221188
 
 
   <!--
   Meta data
   Hash:985071ee68275279789855afa4c781e2d012ea02 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142877777 TriggerType:PUSH TriggerID:985071ee68275279789855afa4c781e2d012ea02
   Hash:985071ee68275279789855afa4c781e2d012ea02 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4048 TriggerType:PUSH TriggerID:985071ee68275279789855afa4c781e2d012ea02
   -->
   ## CI report:
   
   * 985071ee68275279789855afa4c781e2d012ea02 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142877777) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4048) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services