You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/18 01:14:19 UTC
[GitHub] [arrow-ballista] avantgardnerio opened a new pull request, #521: Ballista gets a docker image!!!
avantgardnerio opened a new pull request, #521:
URL: https://github.com/apache/arrow-ballista/pull/521
# Which issue does this PR close?
N/A
# Rationale for this change
Now that we know github actions can publish images, let's only publish images on tags by certified apache committers.
# What changes are included in this PR?
described above
# Are there any user-facing changes?
described above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove merged pull request #521: Ballista gets a docker image!!!
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #521:
URL: https://github.com/apache/arrow-ballista/pull/521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on a diff in pull request #521: Ballista gets a docker image!!!
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #521:
URL: https://github.com/apache/arrow-ballista/pull/521#discussion_r1025954367
##########
dev/docker/ballista-standalone.Dockerfile:
##########
@@ -33,6 +33,9 @@ RUN apt-get -qq update && apt-get install -qq -y nginx netcat wget
COPY target/$RELEASE_FLAG/ballista-scheduler /root/ballista-scheduler
COPY target/$RELEASE_FLAG/ballista-executor /root/ballista-executor
+RUN chmod a+x /root/ballista-scheduler && \
+ chmod a+x /root/ballista-executor
Review Comment:
I'd like to merge this to unblock cutting the RC, but it would be good to discuss this in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Jimexist commented on a diff in pull request #521: Ballista gets a docker image!!!
Posted by GitBox <gi...@apache.org>.
Jimexist commented on code in PR #521:
URL: https://github.com/apache/arrow-ballista/pull/521#discussion_r1025929092
##########
dev/docker/ballista-standalone.Dockerfile:
##########
@@ -33,6 +33,9 @@ RUN apt-get -qq update && apt-get install -qq -y nginx netcat wget
COPY target/$RELEASE_FLAG/ballista-scheduler /root/ballista-scheduler
COPY target/$RELEASE_FLAG/ballista-executor /root/ballista-executor
+RUN chmod a+x /root/ballista-scheduler && \
+ chmod a+x /root/ballista-executor
Review Comment:
ideally this should be placed into `/usr/local/bin` or `/usr/bin` so that others can use.
using `/root/` isn't user friendly for non-root users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org