You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/11 07:11:48 UTC

[GitHub] [hudi] YannByron commented on a diff in pull request #7632: [HUDI-3775] Allow for offline compaction of MOR tables via spark streaming

YannByron commented on code in PR #7632:
URL: https://github.com/apache/hudi/pull/7632#discussion_r1066641097


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -455,6 +455,15 @@ object DataSourceWriteOptions {
       + "This could introduce the potential issue that the job is restart(`batch id` is lost) while spark checkpoint write fails, "
       + "causing spark will retry and rewrite the data.")
 
+  val STREAMING_DISABLE_COMPACTION: ConfigProperty[String] = ConfigProperty

Review Comment:
   @jonvex 
   can we use the two `hoodie.compact.schedule.inline` and `hoodie.compact.inline` configs to judge whether the compaction can be disabled in streaming. so we don't have to add a new config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org