You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <ga...@apache.org> on 2014/06/05 19:06:09 UTC
remove @author Javadoc (was: Licensing and legal question)
On Thu, Jun 05, 2014 at 04:02:24PM +0200, Ignasi Barrera wrote:
> * Regarding attribution, to be polite and democratic, I've asked to
> remove the "@author" tags (the pull request which copies Andrea's
> original code has changed some of those tags in the javadoc). To avoid
> conflicts here, I'd asked to remove them, according to the policy
> that's being followed in many other ASF projects.
Can we remove all the @author Javadoc from jclouds? These Potemkin
comments compose roughly 1% of all of core code and have bit-rotted:
$ find -name \*.java | xargs cat | wc -l
518196
$ find -name \*.java | xargs grep @author | wc -l
4493
I can automate removal of these and add a Checkstyle regex to prevent
further graffiti.
--
Andrew Gaul
http://gaul.org/
Re: remove @author Javadoc (was: Licensing and legal question)
Posted by Ignasi Barrera <na...@apache.org>.
+1
El 05/06/2014 19:17, "Everett Toews" <ev...@rackspace.com> escribió:
> +1
>
> On Jun 5, 2014, at 12:06 PM, Andrew Gaul <ga...@apache.org> wrote:
>
> > On Thu, Jun 05, 2014 at 04:02:24PM +0200, Ignasi Barrera wrote:
> >> * Regarding attribution, to be polite and democratic, I've asked to
> >> remove the "@author" tags (the pull request which copies Andrea's
> >> original code has changed some of those tags in the javadoc). To avoid
> >> conflicts here, I'd asked to remove them, according to the policy
> >> that's being followed in many other ASF projects.
> >
> > Can we remove all the @author Javadoc from jclouds? These Potemkin
> > comments compose roughly 1% of all of core code and have bit-rotted:
> >
> > $ find -name \*.java | xargs cat | wc -l
> > 518196
> > $ find -name \*.java | xargs grep @author | wc -l
> > 4493
> >
> > I can automate removal of these and add a Checkstyle regex to prevent
> > further graffiti.
> >
> > --
> > Andrew Gaul
> > http://gaul.org/
>
>
Re: remove @author Javadoc (was: Licensing and legal question)
Posted by Everett Toews <ev...@RACKSPACE.COM>.
+1
On Jun 5, 2014, at 12:06 PM, Andrew Gaul <ga...@apache.org> wrote:
> On Thu, Jun 05, 2014 at 04:02:24PM +0200, Ignasi Barrera wrote:
>> * Regarding attribution, to be polite and democratic, I've asked to
>> remove the "@author" tags (the pull request which copies Andrea's
>> original code has changed some of those tags in the javadoc). To avoid
>> conflicts here, I'd asked to remove them, according to the policy
>> that's being followed in many other ASF projects.
>
> Can we remove all the @author Javadoc from jclouds? These Potemkin
> comments compose roughly 1% of all of core code and have bit-rotted:
>
> $ find -name \*.java | xargs cat | wc -l
> 518196
> $ find -name \*.java | xargs grep @author | wc -l
> 4493
>
> I can automate removal of these and add a Checkstyle regex to prevent
> further graffiti.
>
> --
> Andrew Gaul
> http://gaul.org/
Re: remove @author Javadoc (was: Licensing and legal question)
Posted by Jeremy Daggett <je...@RACKSPACE.COM>.
Much appreciated!
/jd
On 6/9/14, 4:20 PM, "Andrew Gaul" <ga...@apache.org> wrote:
>I ran the sed scripts against all the repositories; please check if I
>missed some or if subsequent commits reintroduced some instances.
>
>On Mon, Jun 09, 2014 at 08:49:36PM +0000, Jeremy Daggett wrote:
>> Thanks Andrew!
>>
>> Were you planning on running this against the other jclouds repos as
>>well?
>>
>> /jd
>>
>> On 6/7/14, 9:52 PM, "Andrew Gaul" <ga...@apache.org> wrote:
>>
>> >I removed all @author annotations and empty Javadoc with some sed
>> >scripts. Checkstyle should ensure that we do not add @author
>> >annotations in the future. Thank you for opening this issue Chris!
>> >
>> >On Fri, Jun 06, 2014 at 10:30:43AM -0600, Chris Custine wrote:
>> >> +1
>> >>
>> >> I added https://issues.apache.org/jira/browse/JCLOUDS-546 a while
>>back
>> >>with
>> >> a comment explaining that these are discouraged by Apache anyway due
>>to
>> >> copyright assignment.
>> >>
>> >> Chris
>> >>
>> >> --
>> >> Chris Custine
>> >>
>> >>
>> >>
>> >> On Thu, Jun 5, 2014 at 11:06 AM, Andrew Gaul <ga...@apache.org> wrote:
>> >>
>> >> > On Thu, Jun 05, 2014 at 04:02:24PM +0200, Ignasi Barrera wrote:
>> >> > > * Regarding attribution, to be polite and democratic, I've asked
>>to
>> >> > > remove the "@author" tags (the pull request which copies Andrea's
>> >> > > original code has changed some of those tags in the javadoc). To
>> >>avoid
>> >> > > conflicts here, I'd asked to remove them, according to the policy
>> >> > > that's being followed in many other ASF projects.
>> >> >
>> >> > Can we remove all the @author Javadoc from jclouds? These Potemkin
>> >> > comments compose roughly 1% of all of core code and have
>>bit-rotted:
>> >> >
>> >> > $ find -name \*.java | xargs cat | wc -l
>> >> > 518196
>> >> > $ find -name \*.java | xargs grep @author | wc -l
>> >> > 4493
>> >> >
>> >> > I can automate removal of these and add a Checkstyle regex to
>>prevent
>> >> > further graffiti.
>> >> >
>> >> > --
>> >> > Andrew Gaul
>> >> > http://gaul.org/
>> >> >
>> >
>> >--
>> >Andrew Gaul
>> >http://gaul.org/
>
>--
>Andrew Gaul
>http://gaul.org/
Re: remove @author Javadoc (was: Licensing and legal question)
Posted by Andrew Gaul <ga...@apache.org>.
I ran the sed scripts against all the repositories; please check if I
missed some or if subsequent commits reintroduced some instances.
On Mon, Jun 09, 2014 at 08:49:36PM +0000, Jeremy Daggett wrote:
> Thanks Andrew!
>
> Were you planning on running this against the other jclouds repos as well?
>
> /jd
>
> On 6/7/14, 9:52 PM, "Andrew Gaul" <ga...@apache.org> wrote:
>
> >I removed all @author annotations and empty Javadoc with some sed
> >scripts. Checkstyle should ensure that we do not add @author
> >annotations in the future. Thank you for opening this issue Chris!
> >
> >On Fri, Jun 06, 2014 at 10:30:43AM -0600, Chris Custine wrote:
> >> +1
> >>
> >> I added https://issues.apache.org/jira/browse/JCLOUDS-546 a while back
> >>with
> >> a comment explaining that these are discouraged by Apache anyway due to
> >> copyright assignment.
> >>
> >> Chris
> >>
> >> --
> >> Chris Custine
> >>
> >>
> >>
> >> On Thu, Jun 5, 2014 at 11:06 AM, Andrew Gaul <ga...@apache.org> wrote:
> >>
> >> > On Thu, Jun 05, 2014 at 04:02:24PM +0200, Ignasi Barrera wrote:
> >> > > * Regarding attribution, to be polite and democratic, I've asked to
> >> > > remove the "@author" tags (the pull request which copies Andrea's
> >> > > original code has changed some of those tags in the javadoc). To
> >>avoid
> >> > > conflicts here, I'd asked to remove them, according to the policy
> >> > > that's being followed in many other ASF projects.
> >> >
> >> > Can we remove all the @author Javadoc from jclouds? These Potemkin
> >> > comments compose roughly 1% of all of core code and have bit-rotted:
> >> >
> >> > $ find -name \*.java | xargs cat | wc -l
> >> > 518196
> >> > $ find -name \*.java | xargs grep @author | wc -l
> >> > 4493
> >> >
> >> > I can automate removal of these and add a Checkstyle regex to prevent
> >> > further graffiti.
> >> >
> >> > --
> >> > Andrew Gaul
> >> > http://gaul.org/
> >> >
> >
> >--
> >Andrew Gaul
> >http://gaul.org/
--
Andrew Gaul
http://gaul.org/
Re: remove @author Javadoc (was: Licensing and legal question)
Posted by Jeremy Daggett <je...@RACKSPACE.COM>.
Thanks Andrew!
Were you planning on running this against the other jclouds repos as well?
/jd
On 6/7/14, 9:52 PM, "Andrew Gaul" <ga...@apache.org> wrote:
>I removed all @author annotations and empty Javadoc with some sed
>scripts. Checkstyle should ensure that we do not add @author
>annotations in the future. Thank you for opening this issue Chris!
>
>On Fri, Jun 06, 2014 at 10:30:43AM -0600, Chris Custine wrote:
>> +1
>>
>> I added https://issues.apache.org/jira/browse/JCLOUDS-546 a while back
>>with
>> a comment explaining that these are discouraged by Apache anyway due to
>> copyright assignment.
>>
>> Chris
>>
>> --
>> Chris Custine
>>
>>
>>
>> On Thu, Jun 5, 2014 at 11:06 AM, Andrew Gaul <ga...@apache.org> wrote:
>>
>> > On Thu, Jun 05, 2014 at 04:02:24PM +0200, Ignasi Barrera wrote:
>> > > * Regarding attribution, to be polite and democratic, I've asked to
>> > > remove the "@author" tags (the pull request which copies Andrea's
>> > > original code has changed some of those tags in the javadoc). To
>>avoid
>> > > conflicts here, I'd asked to remove them, according to the policy
>> > > that's being followed in many other ASF projects.
>> >
>> > Can we remove all the @author Javadoc from jclouds? These Potemkin
>> > comments compose roughly 1% of all of core code and have bit-rotted:
>> >
>> > $ find -name \*.java | xargs cat | wc -l
>> > 518196
>> > $ find -name \*.java | xargs grep @author | wc -l
>> > 4493
>> >
>> > I can automate removal of these and add a Checkstyle regex to prevent
>> > further graffiti.
>> >
>> > --
>> > Andrew Gaul
>> > http://gaul.org/
>> >
>
>--
>Andrew Gaul
>http://gaul.org/
Re: remove @author Javadoc (was: Licensing and legal question)
Posted by Andrew Gaul <ga...@apache.org>.
I removed all @author annotations and empty Javadoc with some sed
scripts. Checkstyle should ensure that we do not add @author
annotations in the future. Thank you for opening this issue Chris!
On Fri, Jun 06, 2014 at 10:30:43AM -0600, Chris Custine wrote:
> +1
>
> I added https://issues.apache.org/jira/browse/JCLOUDS-546 a while back with
> a comment explaining that these are discouraged by Apache anyway due to
> copyright assignment.
>
> Chris
>
> --
> Chris Custine
>
>
>
> On Thu, Jun 5, 2014 at 11:06 AM, Andrew Gaul <ga...@apache.org> wrote:
>
> > On Thu, Jun 05, 2014 at 04:02:24PM +0200, Ignasi Barrera wrote:
> > > * Regarding attribution, to be polite and democratic, I've asked to
> > > remove the "@author" tags (the pull request which copies Andrea's
> > > original code has changed some of those tags in the javadoc). To avoid
> > > conflicts here, I'd asked to remove them, according to the policy
> > > that's being followed in many other ASF projects.
> >
> > Can we remove all the @author Javadoc from jclouds? These Potemkin
> > comments compose roughly 1% of all of core code and have bit-rotted:
> >
> > $ find -name \*.java | xargs cat | wc -l
> > 518196
> > $ find -name \*.java | xargs grep @author | wc -l
> > 4493
> >
> > I can automate removal of these and add a Checkstyle regex to prevent
> > further graffiti.
> >
> > --
> > Andrew Gaul
> > http://gaul.org/
> >
--
Andrew Gaul
http://gaul.org/
Re: remove @author Javadoc (was: Licensing and legal question)
Posted by Chris Custine <ch...@gmail.com>.
+1
I added https://issues.apache.org/jira/browse/JCLOUDS-546 a while back with
a comment explaining that these are discouraged by Apache anyway due to
copyright assignment.
Chris
--
Chris Custine
On Thu, Jun 5, 2014 at 11:06 AM, Andrew Gaul <ga...@apache.org> wrote:
> On Thu, Jun 05, 2014 at 04:02:24PM +0200, Ignasi Barrera wrote:
> > * Regarding attribution, to be polite and democratic, I've asked to
> > remove the "@author" tags (the pull request which copies Andrea's
> > original code has changed some of those tags in the javadoc). To avoid
> > conflicts here, I'd asked to remove them, according to the policy
> > that's being followed in many other ASF projects.
>
> Can we remove all the @author Javadoc from jclouds? These Potemkin
> comments compose roughly 1% of all of core code and have bit-rotted:
>
> $ find -name \*.java | xargs cat | wc -l
> 518196
> $ find -name \*.java | xargs grep @author | wc -l
> 4493
>
> I can automate removal of these and add a Checkstyle regex to prevent
> further graffiti.
>
> --
> Andrew Gaul
> http://gaul.org/
>
Re: remove @author Javadoc (was: Licensing and legal question)
Posted by Andrew Phillips <ap...@qrmedia.com>.
>> * Regarding attribution, to be polite and democratic, I've asked to
>> remove the "@author" tags (the pull request which copies Andrea's
>> original code has changed some of those tags in the javadoc). To avoid
>> conflicts here, I'd asked to remove them, according to the policy
>> that's being followed in many other ASF projects.
>
> Can we remove all the @author Javadoc from jclouds?
Sounds like a plan! +1.
Thanks, Andrew G!
ap