You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/04/01 05:35:00 UTC
[jira] [Commented] (IMPALA-10582) Webpage of Catalogd operations
doesn't sum up operations correctly
[ https://issues.apache.org/jira/browse/IMPALA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312871#comment-17312871 ]
ASF subversion and git services commented on IMPALA-10582:
----------------------------------------------------------
Commit 553af0a1a18e38a854f0b15c4148188bfc9ba82e in impala's branch refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=553af0a ]
IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations
Webpage of catalogd operations doesn't sum up requests correctly.
Instead, the current meaning is summing by tables. As the column name
is "Number of requests", we should sum up by requests.
Tests:
- Manually run test_concurrent_inserts and verify the number is
correct.
Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Reviewed-on: http://gerrit.cloudera.org:8080/17177
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Webpage of Catalogd operations doesn't sum up operations correctly
> ------------------------------------------------------------------
>
> Key: IMPALA-10582
> URL: https://issues.apache.org/jira/browse/IMPALA-10582
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.0
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Minor
> Attachments: catalogd_operations.png
>
>
> IMPALA-6663 adds a web page for catalogd to show all in-progress operations. While doing a stree test for IMPALA-10563, I found that the summary tab doesn't sum up the operations as I expected.
> !catalogd_operations.png|width=869,height=627!
> As shown by the snapshot, I have 5 in-progress FINALIZE_INSERT_INTO operations. But in the "In-progress Catalog Operations Summary" tab, it shows 1. It makes sense to me to show 5 as well.
> I think the reason is in be/src/catalog/catalog-server.cc, we only sum up requests by tables:
> {code:c++}
> void CatalogServer::OperationUsageUrlCallback(
> const Webserver::WebRequest& req, Document* document) {
> ...
> // Create a summary and add it to the document
> map<string, int> aggregated_operations;
> for (const auto& catalog_op : opeartion_usage.catalog_op_counters) {
> ++aggregated_operations[catalog_op.catalog_op_name]; // <---- should add catalog_op.op_counter here
> }
> ...
> }
> {code}
> cc [~tmate]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org