You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/14 08:32:57 UTC
[GitHub] [flink] Tartarus0zm opened a new pull request #12146: [hotfix][hbase]Fix HBaseRowInputFormat cannot get the zk address set …
Tartarus0zm opened a new pull request #12146:
URL: https://github.com/apache/flink/pull/12146
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Because the `Configuration` in HBaseRowInputFormat cannot be serialized, the task cannot obtain the zk address set in the table parameter, which prevents the task from connecting to Hbase.
Because the default value of `hbase.zookeeper.quorum` is localhost, the unit test is ok
## Brief change log
Fix failure to read hbase table
## Verifying this change
no
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not documented
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268",
"triggerID" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"triggerType" : "PUSH"
}, {
"hash" : "59820867eb46cdb2870ca6500ac93858923590f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2460",
"triggerID" : "59820867eb46cdb2870ca6500ac93858923590f9",
"triggerType" : "PUSH"
}, {
"hash" : "ea008e0dffab41f7f3ac373746605cdc3f6a2388",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2502",
"triggerID" : "ea008e0dffab41f7f3ac373746605cdc3f6a2388",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea008e0dffab41f7f3ac373746605cdc3f6a2388 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2502)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-637247709
Build is passed, merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12146: [hotfix][hbase]Fix HBaseRowInputFormat cannot get the zk address set …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268",
"triggerID" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-636584737
@wuchong Thank you very much for your review, I have fixed these issues, please review again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #12146:
URL: https://github.com/apache/flink/pull/12146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12146: [hotfix][hbase]Fix HBaseRowInputFormat cannot get the zk address set …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zenfenan commented on pull request #12146: [hotfix][hbase]Fix HBaseRowInputFormat cannot get the zk address set …
Posted by GitBox <gi...@apache.org>.
zenfenan commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-634832954
@rmetzger This Hadoop Configuration serialization problem comes up every now and then, especially since we have multiple modules which use Hadoop in one way or another.
@kl0u has taken care of this in `flink-sequence-file` which is somewhat similar to `HbaseConfigurationUtil.serializeConfiguration()`, and even in other two modules which I had an opportunity work on (`flink-compress`, `flink-orc`) needed this ability but right now uses a work around[1][2]. With that in mind, I created a 'discuss' thread some time back[3]. Do you think something like what I had proposed in my thread would be a worthy contribution?
[1]https://github.com/apache/flink/blob/master/flink-formats/flink-compress/src/main/java/org/apache/flink/formats/compress/CompressWriterFactory.java#L87:L96
[2]https://github.com/apache/flink/blob/master/flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/OrcBulkWriterFactory.java#L93:L102
[3]https://lists.apache.org/thread.html/rf885987160bede5911a7f61923307a6d5ae07f850da0a90555728e5f%40%3Cdev.flink.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12146: [hotfix][hbase]Fix HBaseRowInputFormat cannot get the zk address set …
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628482134
@wuchong can you review this for me if you have time, thanks ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268",
"triggerID" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"triggerType" : "PUSH"
}, {
"hash" : "59820867eb46cdb2870ca6500ac93858923590f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2460",
"triggerID" : "59820867eb46cdb2870ca6500ac93858923590f9",
"triggerType" : "PUSH"
}, {
"hash" : "ea008e0dffab41f7f3ac373746605cdc3f6a2388",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ea008e0dffab41f7f3ac373746605cdc3f6a2388",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59820867eb46cdb2870ca6500ac93858923590f9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2460)
* ea008e0dffab41f7f3ac373746605cdc3f6a2388 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268",
"triggerID" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"triggerType" : "PUSH"
}, {
"hash" : "59820867eb46cdb2870ca6500ac93858923590f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2460",
"triggerID" : "59820867eb46cdb2870ca6500ac93858923590f9",
"triggerType" : "PUSH"
}, {
"hash" : "ea008e0dffab41f7f3ac373746605cdc3f6a2388",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2502",
"triggerID" : "ea008e0dffab41f7f3ac373746605cdc3f6a2388",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59820867eb46cdb2870ca6500ac93858923590f9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2460)
* ea008e0dffab41f7f3ac373746605cdc3f6a2388 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2502)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-635064897
Thanks for the contribution @Tartarus0zm . I ajusted the title to the corresponding JIRA issue.
Regarding to the fix, I agree with @rmetzger , we should use `HBaseConfigurationUtil.serializeConfiguration()` to serialize the conf, because there is not only the zk information in it. You can refer to `HBaseLookupFunction` about how to do it.
Besides, `HBaseRowDataInputFormat` is copied from `HBaseRowInputFormat` which has the same problem. It would be nice if you can fix it too.
Another thing is about the testing, the current IT case can pass is because it adds the hbase site xml to the classloader which is not correct in a real environment. I think we should remove [`registerHBaseMiniClusterInClasspath`](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/util/HBaseTestingClusterAutoStarter.java#L181).
A tip: tests in flink-connector-hbase module can't run in IDEA because of class conflicts, but can run using mvn command. You can use `mvn test -Dtest=org.apache.flink.connector.hbase.HBaseConnectorITCase -Dcheckstyle.skip=true` in `flink-connector-hbase` directory to run individual tests (please mvn install the project before running this command).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12146: [hotfix][hbase]Fix HBaseRowInputFormat cannot get the zk address set …
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-634625941
Thanks a lot for your contribution!
`Configuration` is implementing the `Writable` interface, thus it is serializable (in principle). But I agree with you that it seems that the serialization is not done correctly in that interface.
I guess using `HBaseConfigurationUtil.serializeConfiguration()` is a more generic solution than copying two configuration parameters.
I've filed a JIRA ticket for this problem: https://issues.apache.org/jira/browse/FLINK-17968
Are you interested in fixing it? (with a test case to avoid such issues in the future)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12146: [hotfix][hbase]Fix HBaseRowInputFormat cannot get the zk address set …
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-635055620
@rmetzger thanks for your review and suggestion!
I think your suggestion is to refer to https://github.com/apache/flink/blob/5365e40b59fec77de126054746257f17a718fb5b/flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/sink/HBaseSinkFunction.java#L101
Please assign the issue to me, and I will fix it.
thanks~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-635982323
@wuchong @rmetzger I removed the logic of generating hbase-site.xml in the unit test, and must set Hbase configuration when initialize HbaseInputFormat . please take a look , thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12146: [hotfix][hbase]Fix HBaseRowInputFormat cannot get the zk address set …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268",
"triggerID" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12146:
URL: https://github.com/apache/flink/pull/12146#discussion_r432946967
##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/source/AbstractTableInputFormat.java
##########
@@ -99,6 +108,14 @@
*/
public abstract void configure(Configuration parameters);
+ protected void setSerializedConfig(org.apache.hadoop.conf.Configuration hConf) {
+ serializedConfig = HBaseConfigurationUtil.serializeConfiguration(hConf);
+ }
+
+ protected org.apache.hadoop.conf.Configuration getSerializedConfig() {
Review comment:
How about to call it `getHadoopConfiguration` ? Because the returned value is not "serialized".
##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/source/HBaseInputFormat.java
##########
@@ -36,6 +35,10 @@
private static final long serialVersionUID = 1L;
+ public HBaseInputFormat(org.apache.hadoop.conf.Configuration hConf) {
Review comment:
Could you add some Javadoc on this? What is the `hConf` and what values should be contained in the `hConf`?
##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/source/AbstractTableInputFormat.java
##########
@@ -99,6 +108,14 @@
*/
public abstract void configure(Configuration parameters);
+ protected void setSerializedConfig(org.apache.hadoop.conf.Configuration hConf) {
Review comment:
I think we don't need such method, we can directly call `HBaseConfigurationUtil.serializeConfiguration` in the construct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-635139128
@zenfenan Thanks a lot for your summary. I will respond to you on the mailing list, to get this module merged.
@Tartarus0zm Thanks a lot for fixing this issue.
I propose the following timeline:
- @zenfenan and I discuss and prototype the new `flink-hadoop-utils` module
- @Tartarus0zm fixes this issue (using the HBaseConfigurationUtil), and adding good testing
- Either in the initial PR for `flink-hadoop-utils` or in a follow-up PR, we remove the `HBaseConfigurationUtil` and replace it by something generic from `flink-hadoop-utils`.
Agreed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12146: [hotfix][hbase]Fix HBaseRowInputFormat cannot get the zk address set …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628484137
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e (Thu May 14 08:36:23 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268",
"triggerID" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"triggerType" : "PUSH"
}, {
"hash" : "59820867eb46cdb2870ca6500ac93858923590f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2460",
"triggerID" : "59820867eb46cdb2870ca6500ac93858923590f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268)
* 59820867eb46cdb2870ca6500ac93858923590f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2460)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268",
"triggerID" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"triggerType" : "PUSH"
}, {
"hash" : "59820867eb46cdb2870ca6500ac93858923590f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2460",
"triggerID" : "59820867eb46cdb2870ca6500ac93858923590f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59820867eb46cdb2870ca6500ac93858923590f9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2460)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12146:
URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268",
"triggerID" : "2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e",
"triggerType" : "PUSH"
}, {
"hash" : "59820867eb46cdb2870ca6500ac93858923590f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "59820867eb46cdb2870ca6500ac93858923590f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1268)
* 59820867eb46cdb2870ca6500ac93858923590f9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org