You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2012/12/05 12:10:59 UTC
[jira] [Created] (OAK-493) Drop fallback in Node#getPrimaryType
angela created OAK-493:
--------------------------
Summary: Drop fallback in Node#getPrimaryType
Key: OAK-493
URL: https://issues.apache.org/jira/browse/OAK-493
Project: Jackrabbit Oak
Issue Type: Improvement
Reporter: angela
currently the implementation of NodeImpl#getPrimaryType has a fallback if the primary type
property is missing (to nt:unstructured). while that might have been useful in the beginning
when be basically didn't have anything running, i am not convinced that this is really
a reasonable setup for a mature implementation...
the regression i was referring to in OAK-490 wasn't caused by the move itself but by
the fact that i didn't (nor intend to) copy over that shortcut to the node type manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-493) Drop fallback in Node#getPrimaryType
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510430#comment-13510430 ]
Michael Dürig commented on OAK-493:
-----------------------------------
I agree this seems to be more trouble than it's worth.
We should employ a more general mechanism to prevent storing a lot of duplicate string values if this turns out to be a problem. But I think this is better tackled at a lower level.
> Drop fallback in Node#getPrimaryType
> ------------------------------------
>
> Key: OAK-493
> URL: https://issues.apache.org/jira/browse/OAK-493
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Reporter: angela
>
> currently the implementation of NodeImpl#getPrimaryType has a fallback if the primary type
> property is missing (to nt:unstructured). while that might have been useful in the beginning
> when be basically didn't have anything running, i am not convinced that this is really
> a reasonable setup for a mature implementation...
> the regression i was referring to in OAK-490 wasn't caused by the move itself but by
> the fact that i didn't (nor intend to) copy over that shortcut to the node type manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-493) Drop fallback in Node#getPrimaryType
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved OAK-493.
------------------------
Resolution: Fixed
> Drop fallback in Node#getPrimaryType
> ------------------------------------
>
> Key: OAK-493
> URL: https://issues.apache.org/jira/browse/OAK-493
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Reporter: angela
> Assignee: angela
>
> currently the implementation of NodeImpl#getPrimaryType has a fallback if the primary type
> property is missing (to nt:unstructured). while that might have been useful in the beginning
> when be basically didn't have anything running, i am not convinced that this is really
> a reasonable setup for a mature implementation...
> the regression i was referring to in OAK-490 wasn't caused by the move itself but by
> the fact that i didn't (nor intend to) copy over that shortcut to the node type manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OAK-493) Drop fallback in Node#getPrimaryType
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela reassigned OAK-493:
--------------------------
Assignee: angela
> Drop fallback in Node#getPrimaryType
> ------------------------------------
>
> Key: OAK-493
> URL: https://issues.apache.org/jira/browse/OAK-493
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Reporter: angela
> Assignee: angela
>
> currently the implementation of NodeImpl#getPrimaryType has a fallback if the primary type
> property is missing (to nt:unstructured). while that might have been useful in the beginning
> when be basically didn't have anything running, i am not convinced that this is really
> a reasonable setup for a mature implementation...
> the regression i was referring to in OAK-490 wasn't caused by the move itself but by
> the fact that i didn't (nor intend to) copy over that shortcut to the node type manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-493) Drop fallback in Node#getPrimaryType
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510474#comment-13510474 ]
angela commented on OAK-493:
----------------------------
ok... while looking at it i actually found that there is a copy of that
shortcut in the node type manager... i will take care of that as well.
btw, the jcr:primaryType property is defined to be mandatory by nt:base.
so, having the check for mandatory items enable in the type validator
renders that fallback pretty useless anyway.
> Drop fallback in Node#getPrimaryType
> ------------------------------------
>
> Key: OAK-493
> URL: https://issues.apache.org/jira/browse/OAK-493
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Reporter: angela
>
> currently the implementation of NodeImpl#getPrimaryType has a fallback if the primary type
> property is missing (to nt:unstructured). while that might have been useful in the beginning
> when be basically didn't have anything running, i am not convinced that this is really
> a reasonable setup for a mature implementation...
> the regression i was referring to in OAK-490 wasn't caused by the move itself but by
> the fact that i didn't (nor intend to) copy over that shortcut to the node type manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira