You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/08/12 17:00:40 UTC

[Bug 56842] New: Simplify Cipher code in OpenSSL syntax

https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

            Bug ID: 56842
           Summary: Simplify Cipher code in OpenSSL syntax
           Product: Tomcat 8
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: emmanuel.hugonnet@gmail.com

Created attachment 31909
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31909&action=edit
Patch for simpler code

The cipher code in openssl syntax could take advantage of varargs to make it
easier to use.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 56842] Simplify Cipher code in OpenSSL syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

--- Comment #4 from Filip Hanik <fh...@apache.org> ---
(In reply to Remy Maucherat from comment #3)
> Let's see if someone seconds your "veto", which is not justified with
> legitimate arguments at the moment since varargs are probably cleaner in the
> code than arrays. So for now, it is invalid, please change that to -0 at
> least :)

I agree with Remy on this one. -1 rejection based on code style is something we
must move away from in order to encourage more contributions. It's already hard
enough to contribute code through patches as it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 56842] Simplify Cipher code in OpenSSL syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

Remy Maucherat <re...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |---

--- Comment #3 from Remy Maucherat <re...@apache.org> ---
Let's see if someone seconds your "veto", which is not justified with
legitimate arguments at the moment since varargs are probably cleaner in the
code than arrays. So for now, it is invalid, please change that to -0 at least
:)

I'd also like to remind that Emmanuel is the author of the OpenSSL code that
was contributed..

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 56842] Simplify Cipher code in OpenSSL syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

ehsavoie <em...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31909|0                           |1
        is obsolete|                            |

--- Comment #1 from ehsavoie <em...@gmail.com> ---
Created attachment 31910
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31910&action=edit
Fixing the patch as it was in reverse mode

Fixing the patch as it was in reverse mode

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 56842] Simplify Cipher code in OpenSSL syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

--- Comment #5 from ehsavoie <em...@gmail.com> ---
Hum I don't agree : you have a lot of null values or a lot of verbosity with
arrays which leads to less readibility.
In the current code you have :
 - jsse name (as a enum constant)
 - openssl name
 - jsse aliases

Also I might add that moving the aliases to the end makes the code closer to
the declaration in openssl code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 56842] Simplify Cipher code in OpenSSL syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 56842] Simplify Cipher code in OpenSSL syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

--- Comment #6 from Konstantin Kolinko <kn...@gmail.com> ---
(In reply to Remy Maucherat from comment #3)
Ack. I revoke my veto and abstain from voting.
I still do not see much worth in this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 56842] Simplify Cipher code in OpenSSL syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #2 from Konstantin Kolinko <kn...@gmail.com> ---
In the current code the jsse and openssl names are near each other. It makes it
 easier to review them. Your patch breaks that, so I am -1.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 56842] Simplify Cipher code in OpenSSL syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

--- Comment #8 from Remy Maucherat <re...@apache.org> ---
Sorry for the formatting trouble. I understand the order argument.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 56842] Simplify Cipher code in OpenSSL syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56842

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Mark Thomas <ma...@apache.org> ---
Remy has applied this path so closing the issue.

I too preferred the JSSE names closer to the OpenSSL names which is why I
didn't use varargs when I added the JSSE names in the first place. The var args
is cleaner but it does make it a little harder to review since the names are
further apart. I guess this makes me -0 on the move to varargs.

The original patch could have done more on the cleaner code front by making the
formatting of the cipher definitions more consistent rather than less
consistent. I've just done a couple of global search and replaces to fix the
inconsistencies introduced by this patch and some others I spotted.

The original patch also introduced some trailing whitespace (now removed) and a
redundant type argument (also removed).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org