You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/22 19:27:33 UTC

[GitHub] [kafka] lushilin opened a new pull request #8535: KAFKA-9903

lushilin opened a new pull request #8535:
URL: https://github.com/apache/kafka/pull/8535


   ShutdownComplete will countdown in the finally block when thread shutdown due to an error, and in this case thread is not running.
   So isRunning logic should check isShutdownInitiated and isShutdownComplete.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] lushilin commented on pull request #8535: KAFKA-9903

Posted by GitBox <gi...@apache.org>.
lushilin commented on pull request #8535:
URL: https://github.com/apache/kafka/pull/8535#issuecomment-619326049


   ok,i will write test case and run unit test locally


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] lushilin commented on issue #8535: KAFKA-9903

Posted by GitBox <gi...@apache.org>.
lushilin commented on issue #8535:
URL: https://github.com/apache/kafka/pull/8535#issuecomment-617984080


   @guozhangwang @ijuma @junrao PTAL, thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #8535: KAFKA-9903

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8535:
URL: https://github.com/apache/kafka/pull/8535#issuecomment-619168284


   test this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #8535: KAFKA-9903

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8535:
URL: https://github.com/apache/kafka/pull/8535#issuecomment-619273600


   Also could you run the unit test suite locally (you can see `README.md` for instructions), the jenkins failures seem relevant.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #8535: KAFKA-9903

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8535:
URL: https://github.com/apache/kafka/pull/8535#issuecomment-619273287






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org