[GitHub] spark pull request: Spark-3213 Fixes issue with spark-ec2 not dete...

[vidaha <gi...@git.apache.org>]

Github user vidaha commented on the pull request:

    https://github.com/apache/spark/pull/2163#issuecomment-53626372
  
    @JoshRosen 
    
    Yes, this pull request does fix that issue.
    
    Although it was not the "Name" tag that was causing the problem - I still made that change though to tag with Spark Cluster Tag since I think that's better.
    
    It turns out the problem is - When using "Launch more like this", the tags get associated with the spot request instead of the instance.   There is now code in get_existing_cluster that checks spot_requests for the Spark Cluster Tag, and if it finds that, copies that tag over to the associated instances.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org