[GitHub] brooklyn-server issue #119: Add method HttpFeed.Builder#credentials(Credenti...

[aledsage <gi...@git.apache.org>]

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/119
  
    @bostko Ah, thanks for explaining the use-case. Could we instead fix that with an overloaded method:
    
            public Builder credentials(Supplier<String> username, Supplier<String> password) { ...
    
    Under-the-covers, that could either instantiate a mutable `UsernameAndPasswordCredentials`.
    
    We'd need to be careful with a mutable credentials object. I'm not sure how well `HttpClient` will cope with being instantiated with mutable credentials. Hopefully it would be ok; I've never tried. (we create the `HttpClient` in `HttpFeed.preStart()`, and then re-use it for each poll.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---