[jira] [Commented] (JCR-3850) RepositoryStartupServlet constructs FileStore incorrectly

["Marcel Reutegger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369507#comment-14369507 ] 

Marcel Reutegger commented on JCR-3850:
---------------------------------------

Merged into 2.8 branch: http://svn.apache.org/r1667791

> RepositoryStartupServlet constructs FileStore incorrectly
> ---------------------------------------------------------
>
>                 Key: JCR-3850
>                 URL: https://issues.apache.org/jira/browse/JCR-3850
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-webapp
>    Affects Versions: 2.8.1, 2.9.2
>            Reporter: Erik Arvidson
>            Assignee: Marcel Reutegger
>             Fix For: 2.8.1, 2.9.2
>
>         Attachments: JCR-3850.patch
>
>
> The RepositoryStartupServlet in trunk (I am using release/tag 2.8.0 in testing) incorrectly constructs FileStore by passing 256*1024*1024 in the maxFileSizeMB parameter; as documented, this parameter's value is multiplied by 1048576 again in FileStore(BlobStore, File, NodeState, int, int, boolean) which causes the integer to overflow.
> The overflow causes the FileStore's maxFileSize to be 0, which unsurprisingly causes a crash later on in initialization of the store. A simple patch is attached to resolve this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)