You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/08/14 03:14:56 UTC

Review Request 24685: SAMZA-380

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24685/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-380
    https://issues.apache.org/jira/browse/SAMZA-380


Repository: samza-hello-samza


Description
-------

add log4j appender. update reviewboard to use latest branch. move hdfs dependency into dependency versions for better maven styling.


Diffs
-----

  .reviewboardrc dc119baf98782d13aa2ef85fcb28887b4020da3c 
  pom.xml 698fa5bbfa1e2e15da9c7db4c2dca8ffa2259112 
  samza-job-package/pom.xml 796c43945e9bd5684b6186f80217e8d7a7dc1230 
  samza-job-package/src/main/assembly/src.xml 14a5ad511ce06763776a1ea2e94346a622a54259 
  samza-job-package/src/main/resources/log4j.xml a9371655e8edd2426aff113dc33f481d7a2aa053 

Diff: https://reviews.apache.org/r/24685/diff/


Testing
-------


Thanks,

Chris Riccomini


Re: Review Request 24685: SAMZA-380

Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24685/#review50589
-----------------------------------------------------------

Ship it!


Ship It!

- Chinmay Soman


On Aug. 14, 2014, 1:14 a.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24685/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 1:14 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-380
>     https://issues.apache.org/jira/browse/SAMZA-380
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> add log4j appender. update reviewboard to use latest branch. move hdfs dependency into dependency versions for better maven styling.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc dc119baf98782d13aa2ef85fcb28887b4020da3c 
>   pom.xml 698fa5bbfa1e2e15da9c7db4c2dca8ffa2259112 
>   samza-job-package/pom.xml 796c43945e9bd5684b6186f80217e8d7a7dc1230 
>   samza-job-package/src/main/assembly/src.xml 14a5ad511ce06763776a1ea2e94346a622a54259 
>   samza-job-package/src/main/resources/log4j.xml a9371655e8edd2426aff113dc33f481d7a2aa053 
> 
> Diff: https://reviews.apache.org/r/24685/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>


Re: Review Request 24685: SAMZA-380

Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24685/#review50559
-----------------------------------------------------------

Ship it!


Ship It!

- Yan Fang


On Aug. 14, 2014, 1:14 a.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24685/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 1:14 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-380
>     https://issues.apache.org/jira/browse/SAMZA-380
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> add log4j appender. update reviewboard to use latest branch. move hdfs dependency into dependency versions for better maven styling.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc dc119baf98782d13aa2ef85fcb28887b4020da3c 
>   pom.xml 698fa5bbfa1e2e15da9c7db4c2dca8ffa2259112 
>   samza-job-package/pom.xml 796c43945e9bd5684b6186f80217e8d7a7dc1230 
>   samza-job-package/src/main/assembly/src.xml 14a5ad511ce06763776a1ea2e94346a622a54259 
>   samza-job-package/src/main/resources/log4j.xml a9371655e8edd2426aff113dc33f481d7a2aa053 
> 
> Diff: https://reviews.apache.org/r/24685/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>