[GitHub] spark pull request: [SPARK-4005][CORE] handle message replies in r...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2853#discussion_r21345364
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
    @@ -351,23 +350,23 @@ class BlockManagerMasterActor(val isLocal: Boolean, conf: SparkConf, listenerBus
           storageLevel: StorageLevel,
           memSize: Long,
           diskSize: Long,
    -      tachyonSize: Long) {
    +      tachyonSize: Long): Boolean = {
     
    +    var updated = true
         if (!blockManagerInfo.contains(blockManagerId)) {
           if (blockManagerId.isDriver && !isLocal) {
             // We intentionally do not register the master (except in local mode),
             // so we should not indicate failure.
    -        sender ! true
    +        // do nothing here, "updated == true".
    --- End diff --
    
    Why not just `return true` here, and `return false` in the other branch so that we can eliminate the mutable `updated` variable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org