You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juha Alatalo (JIRA)" <ji...@apache.org> on 2007/10/15 11:28:53 UTC
[jira] Created: (WICKET-1077) VisitChildren + IComponentResolver
broken in beta 4?
VisitChildren + IComponentResolver broken in beta 4?
----------------------------------------------------
Key: WICKET-1077
URL: https://issues.apache.org/jira/browse/WICKET-1077
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-beta4
Environment: JDK 1.5
Reporter: Juha Alatalo
Attachments: VisitChildrenExample.zip
If the components are added on the page using ComponentResolver, visitChildren() method seems to be working incorrectly. Created following example which works in beta 3 but not in beta 4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1077) VisitChildren + IComponentResolver
broken in beta 4?
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp reassigned WICKET-1077:
-----------------------------------
Assignee: Matej Knopp
> VisitChildren + IComponentResolver broken in beta 4?
> ----------------------------------------------------
>
> Key: WICKET-1077
> URL: https://issues.apache.org/jira/browse/WICKET-1077
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Environment: JDK 1.5
> Reporter: Juha Alatalo
> Assignee: Matej Knopp
> Attachments: VisitChildrenExample.zip
>
>
> If the components are added on the page using ComponentResolver, visitChildren() method seems to be working incorrectly. Created following example which works in beta 3 but not in beta 4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1077) VisitChildren + IComponentResolver
broken in beta 4?
Posted by "Juha Alatalo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juha Alatalo updated WICKET-1077:
---------------------------------
Attachment: VisitChildrenExample.zip
Example
> VisitChildren + IComponentResolver broken in beta 4?
> ----------------------------------------------------
>
> Key: WICKET-1077
> URL: https://issues.apache.org/jira/browse/WICKET-1077
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Environment: JDK 1.5
> Reporter: Juha Alatalo
> Attachments: VisitChildrenExample.zip
>
>
> If the components are added on the page using ComponentResolver, visitChildren() method seems to be working incorrectly. Created following example which works in beta 3 but not in beta 4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1077) VisitChildren + IComponentResolver
broken in beta 4?
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535003 ]
Matej Knopp commented on WICKET-1077:
-------------------------------------
This doesn't seem to be a bug in Wicket. In fact, the bug was that it worked before. IComponentResolve.resolve is called during render when any modifications to component hierarchy are not permitted. So the resolved component needs to be added through the autoAdd method, which removes the component immediately after it's done rendering. So when you call visitChildren during the label rendering, the component is no longer there.
Even if we kept the component, it still wouldn't work when you e.g. put the label before the resolver, as when label is being rendered, the component is not yet resolved (added to page), because it's only resolved during the render phase.
> VisitChildren + IComponentResolver broken in beta 4?
> ----------------------------------------------------
>
> Key: WICKET-1077
> URL: https://issues.apache.org/jira/browse/WICKET-1077
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Environment: JDK 1.5
> Reporter: Juha Alatalo
> Assignee: Matej Knopp
> Attachments: VisitChildrenExample.zip
>
>
> If the components are added on the page using ComponentResolver, visitChildren() method seems to be working incorrectly. Created following example which works in beta 3 but not in beta 4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1077) VisitChildren + IComponentResolver
broken in beta 4?
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner closed WICKET-1077.
-----------------------------------
Resolution: Fixed
auto add components are not removed in the detach phase. So they should be there in the render phase (after they have been added ofcourse)
> VisitChildren + IComponentResolver broken in beta 4?
> ----------------------------------------------------
>
> Key: WICKET-1077
> URL: https://issues.apache.org/jira/browse/WICKET-1077
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Environment: JDK 1.5
> Reporter: Juha Alatalo
> Assignee: Matej Knopp
> Fix For: 1.3.0-beta5
>
> Attachments: VisitChildrenExample.zip
>
>
> If the components are added on the page using ComponentResolver, visitChildren() method seems to be working incorrectly. Created following example which works in beta 3 but not in beta 4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.