[jira] [Commented] (YETUS-423) Make sortorder and sorttype of type choices

["Yetus QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366546#comment-15366546 ] 

Yetus QA commented on YETUS-423:
--------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green}  0m  8s{color} | {color:green} There were no new pylint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m  0s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  1m 28s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/yetus:e4e4903 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12816678/YETUS-423.00.patch |
| JIRA Issue | YETUS-423 |
| Optional Tests |  pylint  |
| uname | Linux 18b831335a79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 0f3e09d |
| pylint | v1.5.6 |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/431/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Make sortorder and sorttype of type choices
> -------------------------------------------
>
>                 Key: YETUS-423
>                 URL: https://issues.apache.org/jira/browse/YETUS-423
>             Project: Yetus
>          Issue Type: Improvement
>            Reporter: Ajay Yadava
>            Priority: Minor
>         Attachments: YETUS-423.00.patch
>
>
> sortorder and sorttype can take only specific values, so it will be better to make them choices. A common scenario where this will help is a command like below
> python releasedocmaker.py --version trunk --project falcon -t "Apache Falcon" --outputdir result --sortorder desc --sorttype issueid
> (Note that the sortorder is "desc" instead of the permitted "dec")
> This command will sort the issues in ascending order instead of descending order and is a potential source of confusion given that it is a common typo to give sortorder as "desc".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)